Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components: Implemented select boxes and tags components to support multi-select & free response list fields #4

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

natalialuzuriaga
Copy link
Contributor

@natalialuzuriaga natalialuzuriaga commented Dec 16, 2024

Problem

Currently, the form only supports text fields and single select fields. To collect information for fields like platforms, categories, etc. we need to implement more components.

Solution

This PR implements multi-select and free response list components. Now the form can create the following components:

  • Select Boxes
  • Tags

Result

Users can generate forms using json schemas that have fields with `type: array'.

When users fill out the form and click submit, the code.json is generated and downloaded onto their machine.

Test Plan

  1. Start up a HTTP server using python: python3 -m http.server 8000
  2. Click on form.html
  3. Here is the form! Right click -> Inspect to open dev tools
  4. Fill out the form
  5. Click submit and downloads code.json. File contents should match what was submitted in the form!

Will create unit tests in a separate PR after OSAB

@natalialuzuriaga natalialuzuriaga changed the title Components: Implemented select boxes component to support multi-select fields Components: Implemented select boxes and text field component to support multi-select fields Dec 16, 2024
@natalialuzuriaga natalialuzuriaga changed the title Components: Implemented select boxes and text field component to support multi-select fields Components: Implemented select boxes and tags components to support multi-select & free response list fields Dec 17, 2024
@natalialuzuriaga natalialuzuriaga self-assigned this Dec 17, 2024
@natalialuzuriaga natalialuzuriaga added the enhancement New feature or request label Dec 17, 2024
@natalialuzuriaga natalialuzuriaga marked this pull request as ready for review December 17, 2024 16:48
Copy link

@IsaacMilarky IsaacMilarky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@natalialuzuriaga natalialuzuriaga merged commit f7c7b4c into main Dec 19, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants