This repository has been archived by the owner on Jan 13, 2021. It is now read-only.
Feature/stefan/favorites #49
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into feature/stefan/favorites
procateodor
reviewed
May 5, 2020
controllers/shareController.js
Outdated
|
|
||
| exports.getFavorites = async (req, res) => { | ||
| try { | ||
| const share = await req.db.Share.findById(req.param.ShareId) |
There was a problem hiding this comment.
nu o sa mearga asta. Trebuie ObjectId(param.ShareId)
also use shareId and findOne({_id: ..}) instead.
procateodor
reviewed
May 5, 2020
controllers/shareController.js
Outdated
| favorites: user.favoriteCourses | ||
| }) | ||
| } else { | ||
| return res.status(HttpStatus.Unathorized).json({ |
There was a problem hiding this comment.
e cu litere mari UNATHORIZED
procateodor
reviewed
May 5, 2020
controllers/shareController.js
Outdated
| try { | ||
| let newFavoriteCourses = [] | ||
|
|
||
| if (req.user) { |
There was a problem hiding this comment.
no need for this if. The requireAuth middleware do that.
procateodor
reviewed
May 5, 2020
controllers/shareController.js
Outdated
Comment on lines
36
to
46
| for (const course in req.body.coursesToAdd) { | ||
| newFavoriteCourses.push(course) | ||
| } | ||
| for (const course in req.user.favoriteCourses) { | ||
| newFavoriteCourses.push(course) | ||
| } | ||
| newFavoriteCourses = [new Set(newFavoriteCourses)] | ||
|
|
||
| for (const course in req.body.coursesToRemove) { | ||
| newFavoriteCourses.filter((item, index) => item !== course) | ||
| } |
There was a problem hiding this comment.
not work. you should first get the user: User.findOne({_id: ObjectId(req.user[idClaim])})
after add the new courses user.favoriteCourses = new Set(...user.favoriteCourses, ...body.coursesToAdd)
after filter them user.favoriteCourses.filter(course => coursesToRemove.includes(course))
procateodor
reviewed
May 5, 2020
controllers/shareController.js
Outdated
|
|
||
| await req.db.User.updateOne( | ||
| { _id: ObjectId(req.user[idClaim]) }, | ||
| { password: newFavoriteCourses } |
procateodor
reviewed
May 5, 2020
controllers/shareController.js
Outdated
| try { | ||
| let newRecivers = [] | ||
|
|
||
| if (req.user) { |
procateodor
reviewed
May 5, 2020
controllers/shareController.js
Outdated
Comment on lines
76
to
86
| for (const reciverId in req.body.reciverToAdd) { | ||
| newRecivers.push(reciverId) | ||
| } | ||
| for (const reciverId in req.share.recivers) { | ||
| newRecivers.push(reciverId) | ||
| } | ||
| newRecivers = [new Set(newRecivers)] | ||
|
|
||
| for (const reciverId in req.body.reciverToRemove) { | ||
| newRecivers.filter((item, index) => item !== reciverId) | ||
| } |
procateodor
reviewed
May 5, 2020
controllers/shareController.js
Outdated
| for (const reciverId in req.body.reciverToRemove) { | ||
| newRecivers.filter((item, index) => item !== reciverId) | ||
| } | ||
| const share = req.db.Share.find({ ownerId: req.user.id }) |
There was a problem hiding this comment.
this should be done first and edit the share item
procateodor
reviewed
May 5, 2020
controllers/shareController.js
Outdated
| } | ||
| const share = req.db.Share.find({ ownerId: req.user.id }) | ||
| await req.db.Share.updateOne( | ||
| { _id: share._id }, |
procateodor
reviewed
May 5, 2020
models/share.js
Outdated
|
|
||
| const shareSchema = new Schema( | ||
| { | ||
| owner: { |
There was a problem hiding this comment.
You used ownerId in controller
procateodor
reviewed
May 5, 2020
routes/index.js
Outdated
| @@ -15,7 +16,7 @@ router.get('/', (req, res) => { | |||
| }) | |||
|
|
|||
| router.use('/auth', auth) | |||
|
|
|||
| router.use('/share', share) | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added routes to get shares and to add/remove courses from favorites