Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Remove yarn.lock file #1117

Closed
karkir0003 opened this issue Jan 28, 2024 · 3 comments
Closed

[BUG]: Remove yarn.lock file #1117

karkir0003 opened this issue Jan 28, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@karkir0003
Copy link
Member

Operating system

N/A

Bug description

Context
DLP transitioned from yarn to pnpm as the package manager for frontend dependencies. However, in the frontend/ directory of the project, the yarn.lock file still persists. We don't require this file as a pnpm-lock.yaml file is generated from pnpm.

Solution:

  1. Remove the yarn.lock file from frontend/ directory/folder.
  2. Create a pull request and tag @project Lead in discord (with link to the pull request)

Steps to reproduce

Examine the frontend/ directory and check that the yarn.lock file is there

@karkir0003 karkir0003 added the bug Something isn't working label Jan 28, 2024
Copy link
Contributor

Hello @karkir0003! Thank you for submitting the 🐞Bug Request Form. We appreciate your contribution. 👋

We will look into it and provide a response as soon as possible.

To work on this bug request, you can follow these branch setup instructions:

  1. Checkout the main branch:
```
 git checkout nextjs
```
  1. Pull the latest changes from the remote main branch:
```
 git pull origin nextjs
```
  1. Create a new branch specific to this bug request using the issue number:
    git checkout -b bug-1117

Feel free to make the necessary changes in this branch and submit a pull request when you're ready.

Best regards,
Deep Learning Playground (DLP) Team

@karkir0003 karkir0003 moved this from Backlog to In Progress in DLP Project Board Jan 28, 2024
@karkir0003
Copy link
Member Author

Steps on how to test your changes:

  1. After removing the yarn.lock file from frontend/, please run dlp-cli frontend start and verify that localhost:3000 renders the app. You will also need to run dlp-cli backend start in a separate terminal window to load up the backend

TawhidAhmad added a commit that referenced this issue Jan 28, 2024
@karkir0003 karkir0003 moved this from In Progress to Review in DLP Project Board Jan 28, 2024
github-merge-queue bot pushed a commit that referenced this issue Feb 1, 2024
* Fix bug #1117

* 🎨 Auto-generated directory tree for repository in Architecture.md

---------

Co-authored-by: TawhidAhmad <[email protected]>
@farisdurrani
Copy link
Member

Completed in a previous PR

@github-project-automation github-project-automation bot moved this from Review to Done in DLP Project Board Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

3 participants