Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug #1117 #1118

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Fix bug #1117 #1118

merged 2 commits into from
Feb 1, 2024

Conversation

TawhidAhmad
Copy link
Collaborator

Deletion of yarn.lock file

Github Issue Number Here: <#1117>
What user problem are we solving?
Bug with frontend having yarn.lock file

What solution does this PR provide?
Delete the yarn.lock file in frontend/

Testing Methodology

How did you test your changes and verify that existing functionality is not broken
Opened the localhost and the page was present.

Any other considerations

@TawhidAhmad TawhidAhmad requested a review from a team as a code owner January 28, 2024 04:20
Copy link

sonarcloud bot commented Jan 28, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@farisdurrani
Copy link
Member

Did you try running the frontend to see if it still works? @TawhidAhmad

@TawhidAhmad
Copy link
Collaborator Author

Yes, I tried the frontend and it worked. @farisdurrani

Copy link
Member

@farisdurrani farisdurrani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Feel free to merge @TawhidAhmad

@karkir0003
Copy link
Member

Yes, I tried the frontend and it worked. @farisdurrani

In the future, could you include a screen recording?

@farisdurrani farisdurrani added this pull request to the merge queue Feb 1, 2024
Merged via the queue into nextjs with commit fa19c00 Feb 1, 2024
4 checks passed
@farisdurrani farisdurrani deleted the bug-1117 branch February 1, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants