Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Michelle-part2 #1045

Closed
wants to merge 9 commits into from
Closed

Michelle-part2 #1045

wants to merge 9 commits into from

Conversation

michellewliang
Copy link

Michelle-part2

Github Issue Number Here: <YOUR_GITHUB_ISSUE_NUMBER_HERE (include the hashtag)>
What user problem are we solving?

What solution does this PR provide?

Testing Methodology

How did you test your changes and verify that existing
functionality is not broken

Any other considerations

@michellewliang michellewliang requested a review from a team as a code owner October 31, 2023 22:39
@sweep-ai Sweep AI
Copy link
Contributor

sweep-ai bot commented Oct 31, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@karkir0003
Copy link
Member

@michellewliang can you fix the build checks

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@michellewliang
Copy link
Author

Closed, pull request in wrong repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michellewliang @karkir0003 @farisdurrani @dwu359