Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Build + Directory Tree Workflow Fixes #1049

Merged
merged 6 commits into from
Nov 8, 2023
Merged

Conversation

farisdurrani
Copy link
Member

React Build + Directory Tree Workflow Fixes

Github Issue Number Here: N/A
What user problem are we solving?

  1. Generate directory tree workflow is failing
  2. /serverless does not have an ESLint checker
  3. /frontend's lint was not configured to run automatically in the build check
  4. Multiple /frontend lint errors

What solution does this PR provide?

  1. Upgraded the auto-commit github action from v4 -> v5, fixing generate-directory-tree workflow
  2. Implemented an ESLint checker for /serverless, can run using yarn lint in /serverless
  3. Added pnpm lint to the build check for /frontend. TODO: Add yarn lint to build check for /serverless
  4. Fixed /frontend lint errors, mostly unused vars

Testing Methodology

How did you test your changes and verify that existing
functionality is not broken

  1. Did yarn lint in /serverless, pnpm lint in /frontend
  2. Did pnpm start in /frontend

No issues reported after running these tests

Any other considerations
N/A

@farisdurrani farisdurrani self-assigned this Nov 7, 2023
@farisdurrani farisdurrani requested a review from a team as a code owner November 7, 2023 15:16
Copy link
Contributor

sweep-ai bot commented Nov 7, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.

Copy link

sonarcloud bot commented Nov 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 8 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@farisdurrani farisdurrani added this pull request to the merge queue Nov 8, 2023
Merged via the queue into nextjs with commit 32705b4 Nov 8, 2023
12 checks passed
@farisdurrani farisdurrani deleted the workflow-updates branch November 8, 2023 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants