Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1159-user endpoint updates #1163

Merged
merged 14 commits into from
May 18, 2024
Merged

Bug 1159-user endpoint updates #1163

merged 14 commits into from
May 18, 2024

Conversation

ssh51117
Copy link
Collaborator

Aligned User endpoints to use client and not lib

Github Issue Number Here: #1159
What user problem are we solving?
Inconsistent use of aws-sdk dynamodb imports
What solution does this PR provide?
Standardizes endpoint usage to aws-sdk/client-dynamodb imports
Testing Methodology

How did you test your changes and verify that existing functionality is not broken
checked using postman and ran unit tests to check that everything still works
Any other considerations
also updated notion docs on vitest and dynamodb

@ssh51117 ssh51117 requested a review from a team as a code owner April 12, 2024 00:10
Copy link

sonarcloud bot commented Apr 12, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
15.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link

sonarcloud bot commented May 16, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
31.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link
Member

@karkir0003 karkir0003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved to unblock you

@ssh51117 ssh51117 added this pull request to the merge queue May 18, 2024
Merged via the queue into nextjs with commit f69cdf4 May 18, 2024
8 of 9 checks passed
@ssh51117 ssh51117 deleted the bug-1159 branch May 18, 2024 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants