Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify dev instructions to require docker #1183

Merged
merged 1 commit into from
May 20, 2024

Conversation

andrewpeng02
Copy link
Contributor

@andrewpeng02 andrewpeng02 commented May 19, 2024

Because of the changes to dlp-cli backend start, it's no longer necessary to install the backend manually. See DSGT-DLP/dlp-cli#16

output.mp4

@andrewpeng02 andrewpeng02 requested a review from a team as a code owner May 19, 2024 19:54
Copy link
Contributor

sweep-ai bot commented May 19, 2024

Sweep: PR Review

README.md

The changes update the README.md to include Docker Desktop as a prerequisite, remove Docker from the recommended tools, and streamline backend package installation by automating it during the backend start process.

Sweep Found These Issues

  • Removing the manual backend installation step may cause issues if dlp-cli backend start fails to handle dependency installation correctly.
  • | Install/Update Frontend Packages | `dlp-cli frontend install` |
    It's no longer necessary to install the backend, as the dependencies will be automatically installed when running `dlp-cli backend start`.

    View Diff


training/docker-compose.yml

The change allows the host port for the "web" service to be dynamically set using the BACKEND_PORT environment variable, defaulting to 8000 if not defined.


Copy link

sonarcloud bot commented May 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@karkir0003 karkir0003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this. Could you please attach a demo video?

@andrewpeng02 andrewpeng02 added this pull request to the merge queue May 20, 2024
Merged via the queue into nextjs with commit 93d3419 May 20, 2024
12 checks passed
@andrewpeng02 andrewpeng02 deleted the update_readme_backend_start branch May 20, 2024 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants