Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Altered the config #106

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Altered the config #106

merged 1 commit into from
Jun 14, 2024

Conversation

JonathanHancock0
Copy link
Collaborator

The input value of HARDWARE should be either pdsp or npvd, corresponding to the two websites.

@JonathanHancock0
Altered the config, the input value of HARDWARE should be either pdsp…
1cc0504 
… or npvd, corresponding to the two websites.
@plasorak
Copy link
Collaborator

Actually, could hardware be kept np04_coldbox, np04_hd, etc., but there is another field in the request, which is logbook, that holds pdsp or npvd.

plasorak
plasorak approved these changes Jun 14, 2024
View reviewed changes
Copy link
Collaborator

@plasorak plasorak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good. No need for the hardware anymore.

@JonathanHancock0 JonathanHancock0 merged commit 295a53a into develop Jun 14, 2024
1 check passed
@JonathanHancock0 JonathanHancock0 deleted the jhancock/elisa-config-change branch June 14, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plasorak plasorak plasorak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JonathanHancock0 @plasorak