Skip to content

Commit

Permalink
Remove parseAsyncInStepsWith
Browse files Browse the repository at this point in the history
  • Loading branch information
DZakh committed Jul 10, 2024
1 parent 2235775 commit bc1ba34
Show file tree
Hide file tree
Showing 10 changed files with 944 additions and 1,002 deletions.
1 change: 1 addition & 0 deletions CHANGELOG_NEXT.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
- Added `S.setGlobalConfig`. Now it's possible to customize the behavior of the library:
- Change the default `unknownKeys` strategy for Object from `Strip` to `Strict`
- Disable NaN check for numbers
- Removed `parseAsyncInStepsWith` and `parseAnyAsyncInStepsWith` to reduce internal library complexity. Let me know if you need it. I can re-implement it in a future version in a simpler way.

// TODO:

Expand Down
2 changes: 1 addition & 1 deletion IDEAS.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ let trimContract: S.contract<string => string> = S.contract(s => {
- Rename `InvalidJsonStruct` error, since after `rescript-struct`->`rescript-schema` it became misleading
- Add S.bigint
- Add S.promise
- Check only number of fields for strict object schema when fields are not optional

## v???

Expand All @@ -40,3 +39,4 @@ let trimContract: S.contract<string => string> = S.contract(s => {
- s.optional for object
- S.produce
- S.mutator
- Check only number of fields for strict object schema when fields are not optional (bad idea since it's not possible to create a good error message, so we still need to have the loop)
Loading

2 comments on commit bc1ba34

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: bc1ba34 Previous: 06df40b Ratio
Parse string 814462247 ops/sec (±0.41%) 818372259 ops/sec (±0.13%) 1.00
Serialize string 818852036 ops/sec (±0.15%) 819110535 ops/sec (±0.05%) 1.00
Advanced object schema factory 468360 ops/sec (±0.43%) 449156 ops/sec (±0.56%) 0.96
Parse advanced object 56979482 ops/sec (±0.23%) 45100200 ops/sec (±0.16%) 0.79
Assert advanced object 172889860 ops/sec (±0.28%)
Create and parse advanced object 93218 ops/sec (±0.51%) 35041 ops/sec (±1.18%) 0.38
Parse advanced strict object 25102238 ops/sec (±1.04%) 22748126 ops/sec (±0.24%) 0.91
Assert advanced strict object 30571607 ops/sec (±0.41%)
Serialize advanced object 73163347 ops/sec (±0.57%) 806595235 ops/sec (±0.11%) 11.02

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.

Benchmark suite Current: bc1ba34 Previous: 06df40b Ratio
Serialize advanced object 73163347 ops/sec (±0.57%) 806595235 ops/sec (±0.11%) 11.02

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.