Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Zero shot instance segmentation #19

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

f2010126
Copy link

@f2010126 f2010126 commented Oct 9, 2022

Added the README.md.
Please review or merge.
Cheers!
Dipti

@deanp70 deanp70 self-assigned this Oct 16, 2022
Copy link
Member

@deanp70 deanp70 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for participating in Hacktoberfest! I made one comment about the datasets in the body of the file, but adding it here for visibility – currently the dataset itself is tracked but not uploaded to DagsHub, can you please upload it.

Another overarching thing – can you please add topics to the DagsHub repository in the following way:

In the root of the project, add the type of ML task this project tries to solve, as well as anything else that can help other community members discover it.
In each model file, add the model topic so we can make those models accessible directly, see this example in another hacktoberfest project: https://dagshub.com/Bharat-mtr/DeepFlux/src/master/model/0.569_sympascal_iter_40000.caffemodel
In each dataset folder, please add a dataset topic, to make it directly accessible. see this example in another hacktoberfest project: https://dagshub.com/Bharat-mtr/DeepFlux/src/master/data/SK-LARGE/SK-LARGE

After these issues are fixed, we can accept this PR. Thanks again for the awesome contribution!

```
data/coco/train2014/
data/coco/val2014/
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. There is no val2014 folder in the project, only train2014 and test2014, so I'm not sure if we need to change the name of the folder here or in the project, but they are currently incompatible.
  2. The data isn't uploaded to DagsHub even though it seems you locally did track it, would it be possible to push it in, so that these URLs work: https://dagshub.com/f2010126/Zero-shot-Instance-Segmentation/src/main/data/coco/test2014 and https://dagshub.com/f2010126/Zero-shot-Instance-Segmentation/src/main/data/coco/train2014.


# Code for CVPR2021 paper

# **Zero-shot Instance Segmentation**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a link to the DagsHub repository here.

@f2010126
Copy link
Author

Hi @deanp70 ,
Thanks for your patience.
I've done as asked:

  • In the root of the project, add the type of ML task this project tries to solve
  • In each model file, add the model topic so we can make those models accessible directly
  • In each dataset folder, please add a dataset topic, to make it directly accessible

Please let me know if any other changes are needed.

Cheers,
Dipti

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants