ci: upload code coverage in a separate step #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #125 +/- ##
========================================
Coverage 99.03% 99.03%
========================================
Files 16 16
Lines 1353 1353
========================================
Hits 1340 1340
Misses 13 13 ☔ View full report in Codecov by Sentry. |
odrling
force-pushed
the
codecov-upload-step
branch
2 times, most recently
from
34065f8 to
d6e2840
Compare
odrling
changed the title
Wait for all tests to complete before uploading code coverage. Previously the unit tests would upload their results in advance and the codecov bot would report coverage issues in new PRs. As it is, the workflow will not upload code coverage reports if any of the unit or integration tests fail. Which I think is fine.
odrling
force-pushed
the
codecov-upload-step
branch
from
d6e2840 to
999b416
Compare
removes the last deprecation warning remaining in the jobs
Neraste
approved these changes
May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wait for all tests to complete before uploading code coverage. Previously the unit tests would upload their results in advance and the codecov bot would report coverage issues in new PRs.
As it is, the workflow will not upload code coverage reports if any of the unit or integration tests fail. Which I think is fine.