Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display player errors and prepare for client websockets #155

Merged
merged 18 commits into from
Jul 28, 2024

Conversation

Neraste
Copy link
Member

@Neraste Neraste commented Apr 25, 2022

This PR prepares for the use of websockets on the client and has numerous side effects:

  • Rename playlist date_played as date_play;
  • Playlist is integrated to the digest view;
  • Playlist entries in digest view have minimal information to reduce request size;
  • Playlist entries in digest have no pre-calculated date of play anymore, this has to be computed on the client now;
  • Played and queuing playlist entries can be accessed in a library fashion (using pagination), their route was updated to use the played/queuing terminology;
  • Player errors can be fully accessed (initial aim of the PR).

With this design, the digest route can be called to initialize the client to the latest state of the server. When implemented, websockets on the client will ensure punctual updates of the client. For the time being, the digest route can be polled.

@Neraste Neraste added enhancement New feature or request refactor Make things more beautiful inside, but same outside labels Apr 25, 2022
@Neraste Neraste added this to the 1.9.0 milestone Apr 25, 2022
@Neraste Neraste self-assigned this Apr 25, 2022
@codecov
Copy link

codecov bot commented Apr 25, 2022

Codecov Report

Attention: Patch coverage is 98.57143% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.65%. Comparing base (7b916ae) to head (29c40cd).

Files Patch % Lines
dakara_server/playlist/serializers.py 97.14% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #155      +/-   ##
===========================================
- Coverage    98.69%   98.65%   -0.05%     
===========================================
  Files           73       74       +1     
  Lines         1836     1852      +16     
===========================================
+ Hits          1812     1827      +15     
- Misses          24       25       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Neraste Neraste marked this pull request as ready for review July 28, 2024 16:47
@Neraste Neraste merged commit 3f19fbf into develop Jul 28, 2024
18 checks passed
@Neraste Neraste deleted the feature/player_errors branch July 28, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactor Make things more beautiful inside, but same outside
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant