setup ruff as a flake8 replacement #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruff runs pretty fast, which is nice when used as a pre-commit hook. It also implements more checks that can be selected as needed, in this commit I add the bugbear (B) checks which were not present in the previous configuration.
The first one (not binding a loop variable in a local function) can actually result in bugs. Others are mostly minor changes.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #164 +/- ##
========================================
Coverage 98.69% 98.69%
========================================
Files 73 73
Lines 1834 1836 +2
========================================
+ Hits 1810 1812 +2
Misses 24 24 ☔ View full report in Codecov by Sentry. |
|
Nice job, please fix ruff warnings during tests and set ruff version by interval in |
Neraste
approved these changes
Mar 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ruff runs pretty fast, which is nice when used as a pre-commit hook.
It also implements more checks that can be selected as needed, in this
PR I add the bugbear (B) checks which were not present in the
previous configuration and fix issues detected by it.