Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add aria-label to fix to links to provide discernible names #169

Merged
merged 2 commits into from
Jul 21, 2024

Conversation

yolophg
Copy link
Contributor

@yolophg yolophg commented Jul 19, 2024

Checklist before merging

  • Link an issue with the pull request
  • Ensure no errors or warnings on the browser console
  • Avoid additional major pushes after approval (if necessary, request a new review)

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@yolophg yolophg linked an issue Jul 19, 2024 that may be closed by this pull request
@yolophg
Copy link
Contributor Author

yolophg commented Jul 19, 2024

@DaleSeo 최종 리뷰 전, 각 링크 별 aria-label 텍스트 더블체크 한 번 부탁드립니다! 혹시, 수정할 부분 있으면 말씀 주시면 감사드리겠습니다.

  • header 내 로고 : Go to the homepage of Dale Study
  • footer 내 텍스트
    • FAQ : Read the FAQ discussion on LeetCode study group
    • Apply : Apply for LeetCode study group participation
    • Guide : Read the contributing guide for the LeetCode study group
  • footer 내 아이콘
    • 알고달레 : Visit the Algodale website
    • 링크드인 : Visit Dale Seo's LinkedIn profile
    • 깃헙 : Visit the LeetCode study group's GitHub repository
    • 유튜브 : Visit Dale Seo's YouTube channel

@DaleSeo
Copy link
Contributor

DaleSeo commented Jul 19, 2024

@yolophg "Dale Seo's"만 "Dale's"로 바꿔주시면 좋을 것 같아요. 감사합니다!

아 그리고, 우리 스터디 공식 네이밍을 "LeetCode study"가 아니라 "Algorithm study"로 하기로 하지 않았나요? 통일된 이름으로 부르면 좋을 것 같습니다.

- Updated aria-label from 'Dale seo's' to 'Dale's'
- Updated aria-label from 'Leetcode study' to 'Algorithm study'
@yolophg
Copy link
Contributor Author

yolophg commented Jul 19, 2024

@yolophg "Dale Seo's"만 "Dale's"로 바꿔주시면 좋을 것 같아요. 감사합니다!

아 그리고, 우리 스터디 공식 네이밍을 "LeetCode study"가 아니라 "Algorithm study"로 하기로 하지 않았나요? 통일된 이름으로 부르면 좋을 것 같습니다.

넵, 아래와 같이 변경 완료하였습니다!
from Dale seo's to Dale's
from LeetCode study to Algorithm study

@yolophg yolophg marked this pull request as ready for review July 19, 2024 14:15
@yolophg yolophg requested a review from a team as a code owner July 19, 2024 14:15
@DaleSeo DaleSeo merged commit 1b8b850 into main Jul 21, 2024
@DaleSeo DaleSeo deleted the 159-a11y-fix-links-do-not-have-a-discernible-name branch July 21, 2024 01:08
@DaleSeo
Copy link
Contributor

DaleSeo commented Jul 21, 2024

@yolophg 데모 때문에 급하게 제가 머지 했습니당 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[a11y] fix: Links do not have a discernible name
3 participants