Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: solve passing wrong attributes bug #57

Merged
merged 1 commit into from
Jun 16, 2024
Merged

fix: solve passing wrong attributes bug #57

merged 1 commit into from
Jun 16, 2024

Conversation

sounmind
Copy link
Member

@sounmind sounmind commented Jun 16, 2024 •
edited
Loading

  • Extra changes
    • delete import statement in the header.js because it doesn't have to be imported in the header.js

Checklist before merging

  • Link an issue with the pull request
  • Ensure no errors or warnings on the browser console
  • Avoid additional major pushes after approval (if necessary, request a new review)

@sounmind
fix: solve passing wrong attributes bug
d77b74d 
- delete import statement in the header.js because it doesn't have to be imported in the header.js
@sounmind sounmind requested a review from a team as a code owner June 16, 2024 00:47
@sounmind sounmind linked an issue Jun 16, 2024 that may be closed by this pull request
[BUG] fix passing wrong attributes to LinkButton Component in Header Component #56
Closed
@sounmind sounmind requested a review from SamTheKorean June 16, 2024 13:38
SamTheKorean
SamTheKorean approved these changes Jun 16, 2024
View reviewed changes
Copy link
Contributor

@SamTheKorean SamTheKorean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

따로 임포트 해줄 필요가 없었군요...! 수정 감사합니다!

@sounmind sounmind merged commit 8b47903 into main Jun 16, 2024
1 check passed
@sounmind sounmind deleted the 56-bug-fix-passing-wrong-attributes-to-linkbutton-component-in-header-component branch June 16, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamTheKorean SamTheKorean SamTheKorean approved these changes

Assignees

@sounmind sounmind

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] fix passing wrong attributes to LinkButton Component in Header Component
2 participants
@sounmind @SamTheKorean