feat: update button-link with new pattern #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sounmind
changed the title
sounmind
force-pushed
the
64-add-global-css-for-updated-figma-design
branch
from
eef91cf to
663348f
Compare
sounmind
force-pushed
the
44-organize-component-writing-styles
branch
2 times, most recently
from
7d434a2 to
c0225c2
Compare
sounmind
force-pushed
the
44-organize-component-writing-styles
branch
from
c0225c2 to
8955d8d
Compare
DaleSeo
approved these changes
Jun 23, 2024
| @@ -109,7 +26,7 @@ class ButtonLink extends HTMLElement { | |||
|
|
|||
| if (this.hasAttribute("variant")) { | |||
| const variant = this.getAttribute("variant"); | |||
| const validVariants = ["ghost", "secondary"]; | |||
| const validVariants = ["ghost", "primary"]; | |||
There was a problem hiding this comment.
variant 이름이 왜 자꾸 바뀌는 거에요? ㅋ
There was a problem hiding this comment.
처음에 이 색이 회색이길래 primary인 줄 모르고 secondary로 지었다가, global variable에 아예 primary, secondary가 생겨서 이렇게 바꾸게 되었습니다...ㅋㅋ
Base automatically changed from
64-add-global-css-for-updated-figma-design
to
main
June 24, 2024 14:17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before merging