Miscellaneous JS Fixes #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecpm
force-pushed
the
miscellaneous-js-build-cleanup
branch
from
92a30e2
to
caf24d7
Compare
alecpm
changed the base branch from
issues/234-player-item-interaction
to
one-hour-one-life
jessesnyder
approved these changes
Aug 4, 2023
| @@ -1078,7 +1076,7 @@ function onGameStateChange(msg) { | |||
| updateDonationStatus(state.donation_active); | |||
|
|
|||
| // Update gridItems | |||
| if (state.items !== undefined && state.items !== null) { | |||
| if (! _.isNil(state.items)) { | |||
There was a problem hiding this comment.
I think this is isNull() ? https://underscorejs.org/#isNull
There was a problem hiding this comment.
We're using lodash, so it's isNil. There's also isNull in lodash, but this seems like a better fit here. isNull(x) is just x === null so I doubt we'd ever actually want to use it.
| @@ -0,0 +1,4 @@ | |||
| *.js -diff -merge | |||
There was a problem hiding this comment.
I must have just had the file in the wrong place(?) I had it at the repository root.
There was a problem hiding this comment.
It's OK to have in the repository root, but then the glob paths are more difficult I think,
…leanup miscellaneous JS issues and deprecations.
alecpm
force-pushed
the
miscellaneous-js-build-cleanup
branch
from
caf24d7
to
554f3a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some JS cleanup. Add pre-commit hooks to validate YAML and run JS build.