Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Issues/261 ohol docs #262

Merged
merged 11 commits into from
Aug 16, 2023
Merged

Conversation

jessesnyder
Copy link
Contributor

@jessesnyder jessesnyder commented Aug 14, 2023

See #261

@jessesnyder jessesnyder changed the base branch from master to one-hour-one-life August 14, 2023 19:43
@jessesnyder jessesnyder force-pushed the issues/261-ohol-docs branch 3 times, most recently from 5080b2a to f4f8a20 Compare August 15, 2023 22:31
@jessesnyder jessesnyder marked this pull request as ready for review August 15, 2023 22:33

# Does a player need to explicitly interact with this item via the action button
# when they co-occupy its grid block, or do the immediately consume the item
# without needing to take any explicit action?
interactive: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this should default to true since the food special case in the only place we're likely to want it to be false.

# - edge_bias
# - center_bias
#
# See the distributions.py module for their implementations
probability_distribution: "random"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should document how to make a new distribution method? I know Natalia was interested in creating some sort of clustering distribution where items are more likely to appear near other items of the same type.

actor_end: null

# item_id for the item that must be in the player's position in order to execute
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be "player's hand" I think

@jessesnyder
Copy link
Contributor Author

Updates made, @alecpm. Maybe have a look at the notes on custom distribution function.

Copy link
Contributor

@alecpm alecpm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookin' good!

@jessesnyder jessesnyder merged commit f5e511e into one-hour-one-life Aug 16, 2023
2 checks passed
@jessesnyder jessesnyder deleted the issues/261-ohol-docs branch August 16, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants