add more guards on metadata update

Dando18 · Dec 4, 2024 · f352d26 · f352d26
1 parent fe2ab51
commit f352d26
Showing 1 changed file with 14 additions and 10 deletions.
diff --git a/src/scheduler.ts b/src/scheduler.ts
@@ -423,13 +423,15 @@ export class SlurmScheduler implements Scheduler {
             return job.outputFile; /* early exit if it's already defined */
         }
 
-        this.patchJobWithRuntimeMetadata(job);
-        if (job.outputFile) {
-            return job.outputFile;
-        } else {
+        try {
+            this.patchJobWithRuntimeMetadata(job);
+            if (!job.outputFile) {
+                throw new Error('Failed to get job output path.');
+            }
+        } catch (error) {
             vscode.window.showErrorMessage(`Failed to get job output path for job ${job.id}.`);
-            return undefined;
         }
+        return job.outputFile;
     }
 
     /**
@@ -450,13 +452,15 @@ export class SlurmScheduler implements Scheduler {
             return job.errorFile; /* early exit if it's already defined */
         }
 
-        this.patchJobWithRuntimeMetadata(job);
-        if (job.errorFile) {
-            return job.errorFile;
-        } else {
+        try {
+            this.patchJobWithRuntimeMetadata(job);
+            if (!job.errorFile) {
+                throw new Error('Failed to get job error path.');
+            }
+        } catch (error) {
             vscode.window.showErrorMessage(`Failed to get job error path for job ${job.id}.`);
-            return undefined;
         }
+        return job.errorFile;
     }
 }