Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake - Deprecation of versions < 3.5 #92

Open
henrygab opened this issue Sep 19, 2024 · 2 comments
Open

CMake - Deprecation of versions < 3.5 #92

henrygab opened this issue Sep 19, 2024 · 2 comments

Comments

@henrygab
Copy link
Contributor

The following warning appears in the GitHub Action builds.
Should be an easy fix, if someone's up for it.

CMake Deprecation Warning at /home/runner/work/BusPirate5-firmware/BusPirate5-firmware/build/_deps/pico_sdk-src/lib/mbedtls/CMakeLists.txt:23 (cmake_minimum_required):
  Compatibility with CMake < 3.5 will be removed from a future version of
  CMake.
  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.
@wyattearp
Copy link
Contributor

@henrygab as a note - this is an issue with the PICO SDK and the way we're using it in the build process. I ran into this and it's corrected if you use the docker compose build system (or at least it is when I just did a run on the current main 5bbaed7).

The fix (or least I think the fix) is to first perform a build of the picotool system and issue the install (see here) it should go away.

Looking at this again, it is specifically using the 2.0.0 version of the build, which is fine, but also, could probably revert the git repo back to head since this is really used to bootstrap picotool to allow the rest of the checks to operate successfully.

@henrygab
Copy link
Contributor Author

You understand this far better than I do, even with your clear explanations.
I likely don't have the expertise to fix this, so hoping someone else has the background and knowledge to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants