DRAFT - DO NOT MERGE - Add third USB CDC (COM) port for debug output #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`core1_entry()` now calls `debug_uart_init()`. Functionally and order-of-operations identical. Moved to `core1_entry()` to keep items logically grouped, and since `tx_fifo_init()` and `rx_fifo_init()` are called there.
e.g., `%...u` instead of `%...d` for unsigned values Also, on a hunch, calculated the maximum buffer usage that might occur in `ui_statusbar_update()`. This buffer is NOT a queue like the other tx buffers, and there is no blocking behavior (by design) when appending to it. Unfortunately, the manual calculations shows that the maximum characters used far exceeds the statically allocated buffer size. STRONGLY recommend to mark unsafe functions like `sprintf()` as deprecated and use safe alternatives.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For discussion of the feature, review as it is developed, etc.
N.B. - This branch is NOT intended to be merged directly. It has too many changes. Small commits at each step, but still ... too much for one PR. Besides, the second time it's written, things are done more cleanly. 😉
Log
tusb_config.h. Need to re-test to see if this was the primary cause.FetchContent_Populate(pico_sdk)#91 and issue CMake - Deprecation of versions < 3.5 #92.100mA. Not sure if that's OK, so opened new issue USB - Descriptors demand only 100ma #94 to get input and awareness.printfand the like from Core1. May have also found a solution. See new issue Output Channels -- deadlock and generally broken #97.sprintf. Manually calculated worst-case buffer usage for status bar.ui_statusbar_update()theoretically could write1492bytes into the buffer ... which is only1024bytes in size. Conversion to use safe string functions is strongly recommended. See new issue Unsafe String Functions -- Potential Buffer Overflows #98.Users may be presented with UI in a default language, and have trouble selecting their native / preferred language. See new issue LANGUAGE - improve language selection #96.