Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes for #9 #10

Closed
wants to merge 3 commits into from
Closed

Conversation

ob-ivan
Copy link

@ob-ivan ob-ivan commented Aug 24, 2017

Fixes #9

Various improvements made:

  • Handle blocked mic case.
  • Add an option to clear input when button is clicked.
  • Fix a bug on android.

@ob-ivan ob-ivan changed the title Fix #9 Various fixes for #9 Aug 24, 2017
@Daniel-Hug
Copy link
Owner

In desktop chrome, this appears to introduce a bug. In the index.html demo, if I say something, then pause for a moment (but not long enough for it to stop listening), and then start talking again, then my latter speech will overwrite the former. This is all in a single press of the button. I believe the reason I have to wait is so that the browser will set isFinal to true.

@ob-ivan
Copy link
Author

ob-ivan commented Oct 10, 2017

Chrome versions are known to differ across platforms in handling microphone operations, and I don't have enough coverage to keep eye on all of them. The proposed fix worked for those versions tested at my workplace, so I'm going to stick with it. I couldn't reproduce the problem you're talking about, @Daniel-Hug , sorry.

As a result, the fork we use at my workplace has significantly diverged from the upstream, so I give up on keeping them in sync. Closing this one as a no-go.

@ob-ivan ob-ivan closed this Oct 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants