Ghidra symbol importer upgrades #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Tidy up imports - Use SourceType explicitly in code - Add a couple comments about what's happening
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The demangled name is now split into name and namespaces, with the namespaces being created in Ghidra and converted to classes where possible.
Templates, function pointer types, return types, and parameter types are all handled correctly now in the demangling process. The latter two aren't applied to the program yet however, seems a bit out of scope currently (have to make sure all types are resolved, and determining whether or not a
thisparameter exists is a fool's errand with only MWCC symbols).