Copy URL button #327
Open
Copy URL button #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ui/src/components/CopyUrlButton.js
Outdated
|
|
||
| const style = { | ||
| copyUrlButton: { | ||
| marginRight: "16px" |
There was a problem hiding this comment.
React will automatically append a "px" suffix so by convention we do this, to be slightly cleaner:
marginRight: 16
ui/src/components/CopyUrlButton.js
Outdated
| const { className } = this.props; | ||
|
|
||
| return ( | ||
| <div onClick={this.handleButtonClick} style={style.copyUrlButton}> |
There was a problem hiding this comment.
It's recommended to use className rather than style.
In this repo we use the material-ui styling solution.
- At the bottom of this file:
export default withStyles(styles)(CopyUrlButton);
const { classes } = this.props;
... className={classes.copyUrlButton}
There was a problem hiding this comment.
Good to know, thanks! In this case, since we wanted to move the copyUrl button to the left we don't even need the extra styling. So I just removed this altogether.
melissachang
previously approved these changes
Apr 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #325