FE-128 dedup GitHub actions #324
Conversation
…ions with better conditional logic (see FE-128)
…Biosphere/hca-ingest into FE-128-dedup-github-actions
…sue. Testing is not needed in dev as we run this on all PR pushes & syncs. Testing can/should be run locally in dev (takes 90 minutes)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #324 +/- ##
=======================================
Coverage 95.56% 95.56%
=======================================
Files 4 4
Lines 158 158
Branches 5 5
=======================================
Hits 151 151
Misses 7 7 ☔ View full report in Codecov by Sentry. |
|
OK I still don't know why the checks don't line up with the actions - but for now: |
bahill
requested review from
aherbst-broad,
kilonzi,
ahaessly and
ncalvanese1
| - main | ||
| pull_request_target: | ||
| types: | ||
| - closed |
There was a problem hiding this comment.
Technically this runs on any PR that is merged - so even a feature branch off of dev being merged to dev. Is this what is intended? If so, change the name of the workflow and file to remove "main". If you want it to run only for main then maybe merge with the validate pull request workflow.
| @@ -5,6 +5,7 @@ on: | |||
| - main | |||
| jobs: | |||
| pr-validation: | |||
| name: PR Validation | |||
There was a problem hiding this comment.
maybe change the name of this workflow (and file) to indicate this only happens for main.
|
Why
Relevant ticket FE-128
This PR
Added better Git Action logic to the main & dev build actions to allow them to co-exist in the workflows dir.
PR is needed to see if I've fixed the second issue of PRs not showing up in the conversation on PRs. - fixed had to fix some syntax & add the jobs to the branch protection rules.
https://stackoverflow.com/questions/69177488/how-to-set-github-actions-as-required-status-checks
80% fixed - the check status is not syncing with the latest versions of the jobs from updates to this PR. I will dig into that later - it's not critical.
Checklist