[DC-1189] Make name and description required for settings (#1772)

* Make name and description required for settings * Fix test data for settings * Fix integration tests
DataBiosphere · Aug 12, 2024 · 908cf73 · 908cf73
1 parent be8347d
commit 908cf73
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 0 deletions.
diff --git a/src/main/resources/api/data-repository-openapi.yaml b/src/main/resources/api/data-repository-openapi.yaml
@@ -7244,6 +7244,8 @@ components:
       description: >
         ⚠️ The configuration describing how select criteria for issuing a snapshot builder request is generated
       required:
+        - name
+        - description
         - domainOptions
         - programDataOptions
         - featureValueGroups

diff --git a/src/test/java/bio/terra/service/snapshotbuilder/SnapshotBuilderTestData.java b/src/test/java/bio/terra/service/snapshotbuilder/SnapshotBuilderTestData.java
@@ -100,6 +100,8 @@ private static SnapshotBuilderProgramDataListOption generateSnapshotBuilderProgr
 
   public static final SnapshotBuilderSettings SETTINGS =
       new SnapshotBuilderSettings()
+          .name("Snapshot builder settings name")
+          .description("Snapshot builder settings description")
           .domainOptions(
               List.of(
                   generateSnapshotBuilderDomainOption(

diff --git a/src/test/resources/omop/settings.json b/src/test/resources/omop/settings.json
@@ -1,4 +1,6 @@
 {
+  "name": "Integration test settings",
+  "description": "Description for integration test settings",
   "domainOptions": [
     {
       "kind": "domain",

diff --git a/tools/setupResourceScripts/files/OMOPDataset/snapshot_builder_settings.json b/tools/setupResourceScripts/files/OMOPDataset/snapshot_builder_settings.json
@@ -1,4 +1,6 @@
 {
+  "name": "Generated snapshot builder dataset",
+  "description": "A generic OMOP dataset generated by the TDR Setup Resources Script",
   "domainOptions": [
     {
       "kind": "domain",