DT-1108: Use workload identity for GCR SA in cherry pick action #1874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snf2ye
changed the title
snf2ye
changed the title
snf2ye
requested review from
pshapiro4broad and
fboulnois
and removed request for
a team
|
pshapiro4broad
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: https://broadworkbench.atlassian.net/browse/DT-1108
Addresses
Where possible, we should use workload identity rather than rotating service account keys. We hope to get rid of this action soon, but this was a relatively easy change and a proof of concept for other workload identity work. We also were not rotating the keys for this SA, so it will be safer.
Summary of changes
Merge order
Testing Strategy
Successful test run: https://github.com/DataBiosphere/jade-data-repo/actions/runs/12379744534/job/34554576957