Skip to content

Commit

Permalink
CHAOSPLT-455: Skip flaky CI tests (#915)
Browse files Browse the repository at this point in the history
* CHAOSPLT-455: Skip flaky CI tests

* Skip two more flakey tests
  • Loading branch information
ptnapoleon authored Sep 27, 2024
1 parent 846a80f commit 394f848
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
3 changes: 2 additions & 1 deletion controllers/clientset_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ var _ = Describe("Disruption Client", func() {
},
Entry("when there are no disruptions in the cluster", 0, NodeTimeout(k8sAPIServerResponseTimeout)),
Entry("when there is a single disruption in the cluster", 1, NodeTimeout(k8sAPIServerResponseTimeout)),
Entry("when there are three disruptions in the cluster", 3, NodeTimeout(k8sAPIServerResponseTimeout)),
//Entry("when there are three disruptions in the cluster", 3, NodeTimeout(k8sAPIServerResponseTimeout)), // TODO Skip("See CHAOSPLT-455: flaky test")
)
})

Expand Down Expand Up @@ -261,6 +261,7 @@ var _ = Describe("Disruption Client", func() {
Eventually(k8sClient.Delete).WithContext(ctx).WithArguments(&disruption).Within(k8sAPIServerResponseTimeout).ProbeEvery(k8sAPIPotentialChangesEvery).Should(WithTransform(client.IgnoreNotFound, Succeed()), "Failed to delete Disruption")
}),
Entry("when a disruption is updated", watch.Modified, "ds-watch-modify", NodeTimeout(k8sAPIServerResponseTimeout), func(ctx SpecContext, disruptionName string) {
Skip("See CHAOSPLT-455: flaky test")
_ = createDisruption(ctx, namespace, disruptionName)

// Fetch the most up to date disruption
Expand Down
3 changes: 3 additions & 0 deletions controllers/disruption_controller_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@ var _ = Describe("Disruption Controller", func() {
})

It("should target the node", func(ctx SpecContext) {
Skip("See CHAOSPLT-455: flaky test")
By("Ensuring that the inject pod has been created")
ExpectChaosPods(ctx, disruption, 1)
})
Expand All @@ -165,6 +166,7 @@ var _ = Describe("Disruption Controller", func() {
})

It("should target all the selected pods", func(ctx SpecContext) {
Skip("See CHAOSPLT-455: flaky test. Data Race error")
Concurrently{
func(ctx SpecContext) {
By("Ensuring that the chaos pods have been created")
Expand Down Expand Up @@ -514,6 +516,7 @@ var _ = Describe("Disruption Controller", func() {

Context("don't reinject a static node disruption", func() {
BeforeEach(func() {
Skip("See CHAOSPLT-455: flaky test")
disruption.Spec = chaosv1beta1.DisruptionSpec{
DryRun: true,
Duration: "4m",
Expand Down

0 comments on commit 394f848

Please sign in to comment.