Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHAOSPLT-571: Allow for extra ip ranges for GCP cloud disruption #952

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ptnapoleon
Copy link
Contributor

What does this PR do?

  • Adds new functionality
  • Alters existing functionality
  • Fixes a bug
  • Improves documentation or testing

Please briefly describe your changes as well as the motivation behind them:

Code Quality Checklist

  • The documentation is up to date.
  • My code is sufficiently commented and passes continuous integration checks.
  • I have signed my commit (see Contributing Docs).

Testing

  • I leveraged continuous integration testing
    • by depending on existing unit tests or end-to-end tests.
    • by adding new unit tests or end-to-end tests.
  • I manually tested the following steps:
    • x
    • locally.
    • as a canary deployment to a cluster.

@ptnapoleon ptnapoleon requested a review from a team as a code owner January 17, 2025 15:32
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jan 17, 2025

Datadog Report

Branch report: philip/chaosplt-571
Commit report: f421297
Test service: chaos-controller

✅ 0 Failed, 979 Passed, 8 Skipped, 9m 30.77s Total Time

Copy link
Contributor

@clairecng clairecng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Could you also update the doc: https://github.com/DataDog/chaos-controller/blob/main/docs/network_disruption/cloud-managed-services.md#gcp? With what you wrote in your pr description

@ptnapoleon ptnapoleon requested a review from a team January 17, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants