Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Untrack duplicate test snapshots from git #308

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

lym953
Copy link
Contributor

@lym953 lym953 commented Oct 9, 2024

Motivation

Right now, two identical snapshots are created for each stack used by integration tests. For example, lambda_python_stack.py has:

  • correct-lambda_python_stack-snapshot.json
  • test-lambda_python_stack-snapshot.json

The "test" one is supposed to be used locally and not supposed to be committed to git.

What does this PR do?

Remove the "test" snapshots from Git.

Testing Guidelines

aws-vault exec sso-serverless-sandbox-account-admin -- scripts/run_integration_tests.sh still works.

Additional Notes

test-lambda-function-stack-legacy-datadog-api-snapshot.json is empty, which is unexpected. I will take a look and fix it in another PR.

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog

@lym953 lym953 requested a review from a team as a code owner October 9, 2024 21:26
Base automatically changed from yiming.luo/python-stack-test-3 to main October 10, 2024 15:40
@lym953 lym953 force-pushed the yiming.luo/python-stack-test-4 branch from c0ad90a to 74e4d4b Compare October 10, 2024 15:41
@lym953 lym953 merged commit 68d4d7b into main Oct 10, 2024
9 checks passed
@lym953 lym953 deleted the yiming.luo/python-stack-test-4 branch October 10, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants