Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Boto HTTP proxy configuration #3722

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mnussbaum
Copy link

What does this PR do?

This PR fixes Boto's HTTP proxy configuration within the agent.

Boto's proxy argument don't want the protocol on the proxy host.
Configuration within Datadog itself requires this protocol, so strip it
before we pass the proxy host to Boto.

Motivation

We need to proxy our dd-agent traffic out via a HTTP proxy. After configuring the HTTP proxy for the dd-agent we noticed it started failing to retrieve EC2 tags from the AWS API. We tracked the issue down to this misconfigured Boto proxy argument.

We've deployed this fix and seen the dd-agent successfully fetch tags via an HTTP proxy.

Boto's proxy argument don't want the protocol on the proxy host.
Configuration within Datadog itself requires this protocol, so strip it
before we pass the proxy host to Boto.

Signed-off-by: Margarita Sokolova <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant