Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIVIS-9278] Dogfood quality-gates in the CI #1703

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ManuelPalenzuelaDD
Copy link

@ManuelPalenzuelaDD ManuelPalenzuelaDD commented Feb 29, 2024

This patch adds quality gates to the CI. All rules will be non-blocking

What and why?

Quality gates is a new Datadog product. It allows for creating rules that will be evaluated during the CI process (it will block CI pipelines if there are code issues, e.g. new flaky tests).

We are testing a new code coverage rule that will fail if the code coverage of a feature branch decreases by more than a threshold compared to the default branch. It'd be very useful to also test this rule in this repo as it reports code coverage.

This patch integrates quality-gates into the CI, while marking the job as allowed_to_fail, meaning that quality-gates will never block the CI.

How?

Adding a new stage to the CI pipeline that runs quality-gates.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests for Core, RUM, Trace, Logs, CR and WVT
  • Run unit tests for Session Replay
  • Run integration tests
  • Run smoke tests
  • Run tests for tools/

@ManuelPalenzuelaDD ManuelPalenzuelaDD force-pushed the manuel.palenzuela/CIVIS-9278-dogfood-new-quality-gates-code-coverage-rule branch from e98f700 to bd4a37c Compare February 29, 2024 12:24
This patch adds quality gates to the CI. All rules will be non-blocking
@ManuelPalenzuelaDD ManuelPalenzuelaDD force-pushed the manuel.palenzuela/CIVIS-9278-dogfood-new-quality-gates-code-coverage-rule branch from bd4a37c to 841248c Compare February 29, 2024 12:28
@ManuelPalenzuelaDD ManuelPalenzuelaDD marked this pull request as ready for review February 29, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant