-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add background upload configuration info to batch deleted telemetry #2039
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 3491 Passed, 0 Skipped, 2m 19.07s Total Time 🔻 Code Coverage Decreases vs Default Branch (3) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea of collecting this attribute 👍. Although we should introduce a new field rather than re-using existing one for different purpose. Otherwise we will invalidate the spec through this PR.
2510312
to
17ef89b
Compare
/merge |
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
/merge |
🚂 MergeQueue: waiting for PR to be ready This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Use |
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
What and why?
Enriches
Batch Deleted
telemetry metric withbackgroundTaskEnabled
configuration info.This is needed for measuring batch delivery success rate based on existence of the configuration.
How?
I have added new field
background_tasks_enabled
.in_background
is still hardcoded to false, because knowing if the deletion happen in the background is not trivial.Although I think we're mostly interested in measuring the difference is success rate for two different configurations, rather than knowing if batch file was deleted in background/foreground.
Review checklist