RUM-5650 chore: Refine Smoke Tests and add Swift 5.9 coverage #2053
+44
−92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncreated
changed the title
ncreated
changed the title
ncreated
commented
Sep 13, 2024
Comment on lines
-265
to
+235
| - ./tools/runner-setup.sh --xcode "$XCODE" --watchOS --os "$OS" # temporary, waiting for AMI | ||
| - ./tools/runner-setup.sh --xcode "$XCODE" --iOS --tvOS --visionOS --watchOS |
There was a problem hiding this comment.
💡 Current macos:ventura AMI includes all these platforms, but there is no harm in listing them here - the script will just skip what is already installed.
ncreated
force-pushed
the
ncreated/RUM-5650/enhance-smoke-testing-on-ci
branch
from
8815206
to
511917a
Compare
Datadog ReportBranch report: ✅ 0 Failed, 3468 Passed, 0 Skipped, 2m 17.75s Total Time 🔻 Code Coverage Decreases vs Default Branch (4) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
📦 This PR reorganizes and improves the coverage of smoke tests for our iOS SDK. It now includes coverage for all supported Swift versions while maintaining compatibility with various dependency managers.
How?
The
smoke-teststage has been streamlined to 4 key jobs:Smoke Test (iOS) and Smoke Test (tvOS): These jobs test SDK integration through CocoaPods, Carthage, Xcode's SPM, and XCFrameworks. They run on a
macos:sonomarunner with Xcode 15.4.SPM Build (Swift 5.9): This job builds
Package.swiftfor each supported platform using themacos:venturarunner with Xcode 15.2.SPM Build (Swift 5.10): Similar to the above, but for Swift 5.10 using the
macos:sonomarunner with Xcode 15.4.The two "SPM Build" jobs now fully mirror SDK builds in Swift Package Index.
Review checklist