Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RUM-7801] iOS: Session Replay Text Recording in New Architecture #766

Merged

Conversation

marco-saia-datadog
Copy link
Member

What does this PR do?

Introduces handling of RCTParagraphComponentView Fabric components to extract text properties and support Text Recording for Session Replay in new architecture.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)
  • If this PR is auto-generated, please make sure also to manually update the code related to the change

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jan 8, 2025

Datadog Report

Branch report: marcosaia/RUM-7801/ios-newarch-text-props-resolver
Commit report: 1320845
Test service: dd-sdk-reactnative

✅ 0 Failed, 629 Passed, 1 Skipped, 12.12s Total Time

@marco-saia-datadog marco-saia-datadog force-pushed the marcosaia/RUM-7801/ios-newarch-text-props-resolver branch 4 times, most recently from b0a43a3 to 6021903 Compare January 13, 2025 14:31
@marco-saia-datadog marco-saia-datadog force-pushed the marcosaia/RUM-7801/ios-newarch-text-props-resolver branch from 6021903 to 1320845 Compare January 14, 2025 13:52
@marco-saia-datadog marco-saia-datadog marked this pull request as ready for review January 16, 2025 15:40
@marco-saia-datadog marco-saia-datadog requested a review from a team as a code owner January 16, 2025 15:40
if (uiColor != nil) {
return uiColor;
}
} @catch (NSException *exception) {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what can throw exception here?

@marco-saia-datadog marco-saia-datadog merged commit 917bdcb into develop Jan 17, 2025
9 checks passed
@marco-saia-datadog marco-saia-datadog deleted the marcosaia/RUM-7801/ios-newarch-text-props-resolver branch January 17, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants