Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVEMENT] SR: Minor fixes in README.md #771

Merged
merged 1 commit into from
Jan 16, 2025
Merged

[IMPROVEMENT] SR: Minor fixes in README.md #771

merged 1 commit into from
Jan 16, 2025

Conversation

marco-saia-datadog
Copy link
Member

What does this PR do?

Fixes a few typos in README.md for @datadog/mobile-react-native-session-replay.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)
  • If this PR is auto-generated, please make sure also to manually update the code related to the change

@marco-saia-datadog marco-saia-datadog marked this pull request as ready for review January 13, 2025 14:30
@marco-saia-datadog marco-saia-datadog requested review from a team as code owners January 13, 2025 14:30
@datadog-datadog-prod-us1
Copy link

Datadog Report

Branch report: marcosaia/fix/sr-readme-typos
Commit report: 5870d37
Test service: dd-sdk-reactnative

✅ 0 Failed, 630 Passed, 1 Skipped, 12.53s Total Time

rtrieu
rtrieu approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@rtrieu rtrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, but looks good!

@marco-saia-datadog marco-saia-datadog force-pushed the marcosaia/fix/sr-readme-typos branch from 5870d37 to 198fb01 Compare January 16, 2025 13:57
@marco-saia-datadog marco-saia-datadog merged commit ecea3fe into develop Jan 16, 2025
2 of 8 checks passed
@marco-saia-datadog marco-saia-datadog deleted the marcosaia/fix/sr-readme-typos branch January 16, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtrieu rtrieu rtrieu approved these changes

@jonathanmos jonathanmos jonathanmos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marco-saia-datadog @jonathanmos @rtrieu