review comments

contrib/internal/httptrace/before_handle.go

@@ -37,6 +37,10 @@ type ServeConfig struct {
 	SpanOpts []ddtrace.StartSpanOption
 }
 
+// BeforeHandle contains functionality that should be executed before a http.Handler runs.
+// It returns the "traced" http.ResponseWriter and http.Request, an additional afterHandle function
+// that should be executed after the Handler runs, and a handled bool that instructs if the request has been handled
+// or not - in case it was handled, the original handler should not run.
 func BeforeHandle(cfg *ServeConfig, w http.ResponseWriter, r *http.Request) (http.ResponseWriter, *http.Request, func(), bool) {
 	if cfg == nil {
 		cfg = new(ServeConfig)

contrib/julienschmidt/httprouter/internal/tracing/config.go

@@ -20,10 +20,10 @@ import (
 const defaultServiceName = "http.router"
 
 type Config struct {
-	serviceName   string
+	headerTags    *internal.LockMap
 	spanOpts      []ddtrace.StartSpanOption
+	serviceName   string
 	analyticsRate float64
-	headerTags    *internal.LockMap
 }
 
 func NewConfig(opts ...Option) *Config {

contrib/julienschmidt/httprouter/internal/tracing/tracing.go

@@ -31,7 +31,14 @@ type Param interface {
 	GetValue() string
 }
 
-func BeforeHandle[T any, WT Router](cfg *Config, router T, wrapRouter func(T) WT, w http.ResponseWriter, req *http.Request) (http.ResponseWriter, *http.Request, func(), bool) {
+// BeforeHandle is an adapter of httptrace.BeforeHandle for julienschmidt/httprouter types.
+func BeforeHandle[T any, WT Router](
+	cfg *Config,
+	router T,
+	wrapRouter func(T) WT,
+	w http.ResponseWriter,
+	req *http.Request,
+) (http.ResponseWriter, *http.Request, func(), bool) {
 	wRouter := wrapRouter(router)
 	// get the resource associated to this request
 	route := req.URL.Path

internal/appsec/emitter/httpsec/http.go

@@ -108,8 +108,17 @@ func makeCookies(parsed []*http.Cookie) map[string][]string {
 	return cookies
 }
 
-func BeforeHandle(w http.ResponseWriter, r *http.Request, span ddtrace.Span, pathParams map[string]string, opts *Config) (
-	http.ResponseWriter, *http.Request, func(), bool) {
+// BeforeHandle contains the appsec functionality that should be executed before a http.Handler runs.
+// It returns the modified http.ResponseWriter and http.Request, an additional afterHandle function
+// that should be executed after the Handler runs, and a handled bool that instructs if the request has been handled
+// or not - in case it was handled, the original handler should not run.
+func BeforeHandle(
+	w http.ResponseWriter,
+	r *http.Request,
+	span ddtrace.Span,
+	pathParams map[string]string,
+	opts *Config,
+) (http.ResponseWriter, *http.Request, func(), bool) {
 	if opts == nil {
 		opts = defaultWrapHandlerConfig
 	} else if opts.ResponseHeaderCopier == nil {