Fix defaultErrorCode naming

DataDog · Oct 1, 2024 · 767938c · 767938c
1 parent 11d58d9
commit 767938c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/contrib/internal/httptrace/config.go b/contrib/internal/httptrace/config.go
@@ -43,7 +43,7 @@ func newConfig() config {
 		queryString:       !internal.BoolEnv(envQueryStringDisabled, false),
 		queryStringRegexp: defaultQueryStringRegexp,
 		traceClientIP:     internal.BoolEnv(envTraceClientIPEnabled, false),
-		isStatusError:     defaultErrorCodes,
+		isStatusError:     isServerError,
 	}
 	v := os.Getenv(envServerErrorStatuses)
 	if fn := GetErrorCodesFromInput(v); fn != nil {
@@ -62,7 +62,7 @@ func newConfig() config {
 	return c
 }
 
-func defaultErrorCodes(statusCode int) bool {
+func isServerError(statusCode int) bool {
 	return statusCode >= 500 && statusCode < 600
 }
 

diff --git a/contrib/net/http/option.go b/contrib/net/http/option.go
@@ -175,7 +175,7 @@ func newRoundTripperConfig() *roundTripperConfig {
 		spanNamer:     defaultSpanNamer,
 		ignoreRequest: func(_ *http.Request) bool { return false },
 		queryString:   internal.BoolEnv(envClientQueryStringEnabled, true),
-		isStatusError: defaultErrorCodes,
+		isStatusError: isClientError,
 	}
 	v := os.Getenv(envClientErrorStatuses)
 	if fn := httptrace.GetErrorCodesFromInput(v); fn != nil {
@@ -283,6 +283,6 @@ func RTWithErrorCheck(fn func(err error) bool) RoundTripperOption {
 	}
 }
 
-func defaultErrorCodes(statusCode int) bool {
+func isClientError(statusCode int) bool {
 	return statusCode >= 400 && statusCode < 500
 }