Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2: create godoc for contribs #2909

Merged
merged 5 commits into from
Oct 7, 2024
Merged

Conversation

hannahkm
Copy link
Contributor

@hannahkm hannahkm commented Oct 3, 2024

What does this PR do?

Add a godoc page for the contribs folder.

Motivation

The current version of the v2.0.0 godoc page does not have a page for contribs. We should have one to simplify linking between pages and for isolating contrib docs to one page.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@hannahkm hannahkm added the apm:ecosystem contrib/* related feature requests or bugs label Oct 3, 2024
@hannahkm hannahkm changed the base branch from v2-dev to hannah/divergences October 3, 2024 19:15
@pr-commenter
Copy link

pr-commenter bot commented Oct 7, 2024

Benchmarks

Benchmark execution time: 2024-10-07 14:18:58

Comparing candidate commit 1dd4cb1 in PR branch hannah/contrib-doc with baseline commit 7d4b68c in branch hannah/divergences.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 0 unstable metrics.

@hannahkm hannahkm marked this pull request as ready for review October 7, 2024 14:30
@hannahkm hannahkm requested review from a team as code owners October 7, 2024 14:30
@hannahkm
Copy link
Contributor Author

hannahkm commented Oct 7, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Oct 7, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in hannah/divergences is 0s.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit 1a23c93 into hannah/divergences Oct 7, 2024
133 checks passed
@dd-mergequeue dd-mergequeue bot deleted the hannah/contrib-doc branch October 7, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ecosystem contrib/* related feature requests or bugs mergequeue-status: done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants