Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/civisibility: add extra tags to github action pull_requests runs #2922

Merged
merged 3 commits into from
Oct 10, 2024

Conversation

tonyredondo
Copy link
Member

What does this PR do?

This PR adds a couple of CI extra tags when running in GitHub Actions following the ticket: https://datadoghq.atlassian.net/browse/SDTEST-524

Motivation

Test visibility Go implementation is missing these extra tags.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@tonyredondo tonyredondo requested a review from a team as a code owner October 10, 2024 10:55
@tonyredondo tonyredondo self-assigned this Oct 10, 2024
@romainkomorndatadog romainkomorndatadog changed the title internal/civisibility: add extra tags to github action pul_requests runs internal/civisibility: add extra tags to github action pull_requests runs Oct 10, 2024
@pr-commenter
Copy link

pr-commenter bot commented Oct 10, 2024

Benchmarks

Benchmark execution time: 2024-10-10 12:32:17

Comparing candidate commit 5391b19 in PR branch tony/civisibility-add-github-extra-tags with baseline commit fc58656 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 1 unstable metrics.

@tonyredondo tonyredondo merged commit 2f2854f into main Oct 10, 2024
145 checks passed
@tonyredondo tonyredondo deleted the tony/civisibility-add-github-extra-tags branch October 10, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants