Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/civisibility: adds git tree upload feature #2927

Merged
merged 19 commits into from
Oct 16, 2024

Conversation

tonyredondo
Copy link
Member

@tonyredondo tonyredondo commented Oct 14, 2024

What does this PR do?

This PR adds the Git tree upload feature to the CI Visibility library.

specs: https://datadoghq.atlassian.net/wiki/spaces/SDTEST/pages/3123348305/Intelligent+Test+Runner+in+CI+Visibility+Libraries#Git-tree-upload.1

Motivation

All CI Visibility libraries implement this feature, we were missing it.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@tonyredondo tonyredondo self-assigned this Oct 14, 2024
@pr-commenter
Copy link

pr-commenter bot commented Oct 14, 2024

Benchmarks

Benchmark execution time: 2024-10-16 17:43:01

Comparing candidate commit 11112fb in PR branch tony/civisibility-gitprovider-rework with baseline commit 51abc7b in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 0 unstable metrics.

@tonyredondo tonyredondo changed the title internal/civisibility: git provider rework in preparation to upload the git tree feature. internal/civisibility: adds git tree upload feature Oct 15, 2024
@tonyredondo tonyredondo marked this pull request as ready for review October 15, 2024 15:00
@tonyredondo tonyredondo requested a review from a team as a code owner October 15, 2024 15:00
Copy link
Contributor

@ManuelPalenzuelaDD ManuelPalenzuelaDD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tonyredondo tonyredondo force-pushed the tony/civisibility-gitprovider-rework branch from 6cb8867 to 11112fb Compare October 16, 2024 16:59
@tonyredondo tonyredondo merged commit 25d2ba5 into main Oct 16, 2024
144 of 145 checks passed
@tonyredondo tonyredondo deleted the tony/civisibility-gitprovider-rework branch October 16, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants