-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the possibility to output the logs of the Java tracer in JSON #8083
base: master
Are you sure you want to change the base?
Conversation
Hi! 👋 Looks like you updated a Git Submodule.
|
Hi! 👋 Looks like you updated a Git Submodule.
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 4 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.45.0-SNAPSHOT~4cdb964744, baseline=1.45.0-SNAPSHOT~e8df8a0d00
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.055 s) : 0, 1054508
Total [baseline] (8.588 s) : 0, 8588122
Agent [candidate] (1.051 s) : 0, 1051419
Total [candidate] (8.577 s) : 0, 8577365
section iast
Agent [baseline] (1.181 s) : 0, 1180839
Total [baseline] (9.184 s) : 0, 9184213
Agent [candidate] (1.191 s) : 0, 1191000
Total [candidate] (9.241 s) : 0, 9241063
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.179 s) : 0, 1179287
Total [baseline] (9.2 s) : 0, 9199615
Agent [candidate] (1.185 s) : 0, 1185404
Total [candidate] (9.196 s) : 0, 9195918
section iast_TELEMETRY_OFF
Agent [baseline] (1.176 s) : 0, 1176495
Total [baseline] (9.147 s) : 0, 9146658
Agent [candidate] (1.175 s) : 0, 1174736
Total [candidate] (9.168 s) : 0, 9168258
gantt
title insecure-bank - break down per module: candidate=1.45.0-SNAPSHOT~4cdb964744, baseline=1.45.0-SNAPSHOT~e8df8a0d00
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (714.072 ms) : 0, 714072
BytebuddyAgent [candidate] (711.721 ms) : 0, 711721
GlobalTracer [baseline] (256.419 ms) : 0, 256419
GlobalTracer [candidate] (255.912 ms) : 0, 255912
AppSec [baseline] (55.192 ms) : 0, 55192
AppSec [candidate] (54.843 ms) : 0, 54843
Remote Config [baseline] (701.364 µs) : 0, 701
Remote Config [candidate] (712.373 µs) : 0, 712
Telemetry [baseline] (13.063 ms) : 0, 13063
Telemetry [candidate] (13.285 ms) : 0, 13285
section iast
BytebuddyAgent [baseline] (830.627 ms) : 0, 830627
BytebuddyAgent [candidate] (836.814 ms) : 0, 836814
GlobalTracer [baseline] (246.481 ms) : 0, 246481
GlobalTracer [candidate] (249.66 ms) : 0, 249660
AppSec [baseline] (58.052 ms) : 0, 58052
AppSec [candidate] (58.457 ms) : 0, 58457
IAST [baseline] (21.48 ms) : 0, 21480
IAST [candidate] (21.605 ms) : 0, 21605
Remote Config [baseline] (654.72 µs) : 0, 655
Remote Config [candidate] (658.691 µs) : 0, 659
Telemetry [baseline] (8.534 ms) : 0, 8534
Telemetry [candidate] (8.713 ms) : 0, 8713
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (828.968 ms) : 0, 828968
BytebuddyAgent [candidate] (833.084 ms) : 0, 833084
GlobalTracer [baseline] (246.734 ms) : 0, 246734
GlobalTracer [candidate] (247.98 ms) : 0, 247980
AppSec [baseline] (57.899 ms) : 0, 57899
AppSec [candidate] (58.282 ms) : 0, 58282
IAST [baseline] (21.468 ms) : 0, 21468
IAST [candidate] (21.651 ms) : 0, 21651
Remote Config [baseline] (650.127 µs) : 0, 650
Remote Config [candidate] (657.886 µs) : 0, 658
Telemetry [baseline] (8.523 ms) : 0, 8523
Telemetry [candidate] (8.691 ms) : 0, 8691
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (827.036 ms) : 0, 827036
BytebuddyAgent [candidate] (825.587 ms) : 0, 825587
GlobalTracer [baseline] (246.275 ms) : 0, 246275
GlobalTracer [candidate] (246.393 ms) : 0, 246393
AppSec [baseline] (57.85 ms) : 0, 57850
AppSec [candidate] (57.767 ms) : 0, 57767
IAST [baseline] (21.189 ms) : 0, 21189
IAST [candidate] (21.047 ms) : 0, 21047
Remote Config [baseline] (650.228 µs) : 0, 650
Remote Config [candidate] (668.945 µs) : 0, 669
Telemetry [baseline] (8.454 ms) : 0, 8454
Telemetry [candidate] (8.373 ms) : 0, 8373
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.45.0-SNAPSHOT~4cdb964744, baseline=1.45.0-SNAPSHOT~e8df8a0d00
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.075 s) : 0, 1075267
Total [baseline] (10.506 s) : 0, 10506086
Agent [candidate] (1.05 s) : 0, 1050269
Total [candidate] (10.387 s) : 0, 10386754
section appsec
Agent [baseline] (1.191 s) : 0, 1191456
Total [baseline] (10.724 s) : 0, 10723697
Agent [candidate] (1.187 s) : 0, 1186820
Total [candidate] (10.646 s) : 0, 10645726
section iast
Agent [baseline] (1.181 s) : 0, 1180612
Total [baseline] (10.97 s) : 0, 10970282
Agent [candidate] (1.182 s) : 0, 1182202
Total [candidate] (10.919 s) : 0, 10919173
section profiling
Agent [baseline] (1.272 s) : 0, 1272244
Total [baseline] (10.739 s) : 0, 10738568
Agent [candidate] (1.273 s) : 0, 1272540
Total [candidate] (10.779 s) : 0, 10778558
gantt
title petclinic - break down per module: candidate=1.45.0-SNAPSHOT~4cdb964744, baseline=1.45.0-SNAPSHOT~e8df8a0d00
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (727.692 ms) : 0, 727692
BytebuddyAgent [candidate] (712.54 ms) : 0, 712540
GlobalTracer [baseline] (261.715 ms) : 0, 261715
GlobalTracer [candidate] (256.437 ms) : 0, 256437
AppSec [baseline] (56.125 ms) : 0, 56125
AppSec [candidate] (54.931 ms) : 0, 54931
Remote Config [baseline] (733.184 µs) : 0, 733
Remote Config [candidate] (719.353 µs) : 0, 719
Telemetry [baseline] (13.699 ms) : 0, 13699
Telemetry [candidate] (10.638 ms) : 0, 10638
section appsec
BytebuddyAgent [baseline] (731.912 ms) : 0, 731912
BytebuddyAgent [candidate] (729.632 ms) : 0, 729632
GlobalTracer [baseline] (254.779 ms) : 0, 254779
GlobalTracer [candidate] (253.261 ms) : 0, 253261
AppSec [baseline] (170.861 ms) : 0, 170861
AppSec [candidate] (170.485 ms) : 0, 170485
Remote Config [baseline] (664.029 µs) : 0, 664
Remote Config [candidate] (678.462 µs) : 0, 678
Telemetry [baseline] (8.445 ms) : 0, 8445
Telemetry [candidate] (8.038 ms) : 0, 8038
IAST [baseline] (19.52 ms) : 0, 19520
IAST [candidate] (19.541 ms) : 0, 19541
section iast
BytebuddyAgent [baseline] (829.806 ms) : 0, 829806
BytebuddyAgent [candidate] (831.296 ms) : 0, 831296
GlobalTracer [baseline] (246.946 ms) : 0, 246946
GlobalTracer [candidate] (247.017 ms) : 0, 247017
AppSec [baseline] (58.157 ms) : 0, 58157
AppSec [candidate] (57.928 ms) : 0, 57928
Remote Config [baseline] (653.308 µs) : 0, 653
Remote Config [candidate] (646.856 µs) : 0, 647
Telemetry [baseline] (8.647 ms) : 0, 8647
Telemetry [candidate] (8.62 ms) : 0, 8620
IAST [baseline] (21.377 ms) : 0, 21377
IAST [candidate] (21.585 ms) : 0, 21585
section profiling
ProfilingAgent [baseline] (95.24 ms) : 0, 95240
ProfilingAgent [candidate] (95.592 ms) : 0, 95592
BytebuddyAgent [baseline] (702.022 ms) : 0, 702022
BytebuddyAgent [candidate] (702.179 ms) : 0, 702179
GlobalTracer [baseline] (371.499 ms) : 0, 371499
GlobalTracer [candidate] (370.962 ms) : 0, 370962
AppSec [baseline] (53.156 ms) : 0, 53156
AppSec [candidate] (53.57 ms) : 0, 53570
Remote Config [baseline] (674.502 µs) : 0, 675
Remote Config [candidate] (673.238 µs) : 0, 673
Telemetry [baseline] (7.839 ms) : 0, 7839
Telemetry [candidate] (7.798 ms) : 0, 7798
Profiling [baseline] (95.267 ms) : 0, 95267
Profiling [candidate] (95.615 ms) : 0, 95615
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.45.0-SNAPSHOT~4cdb964744, baseline=1.45.0-SNAPSHOT~e8df8a0d00
dateFormat X
axisFormat %s
section baseline
no_agent (381.06 µs) : 362, 401
. : milestone, 381,
iast (490.436 µs) : 469, 512
. : milestone, 490,
iast_FULL (658.327 µs) : 636, 681
. : milestone, 658,
iast_GLOBAL (516.376 µs) : 495, 538
. : milestone, 516,
iast_HARDCODED_SECRET_DISABLED (491.082 µs) : 470, 513
. : milestone, 491,
iast_INACTIVE (454.496 µs) : 433, 476
. : milestone, 454,
iast_TELEMETRY_OFF (484.401 µs) : 463, 506
. : milestone, 484,
tracing (447.647 µs) : 427, 469
. : milestone, 448,
section candidate
no_agent (378.03 µs) : 358, 398
. : milestone, 378,
iast (489.633 µs) : 468, 511
. : milestone, 490,
iast_FULL (653.504 µs) : 632, 675
. : milestone, 654,
iast_GLOBAL (518.143 µs) : 497, 539
. : milestone, 518,
iast_HARDCODED_SECRET_DISABLED (489.61 µs) : 468, 511
. : milestone, 490,
iast_INACTIVE (455.444 µs) : 434, 477
. : milestone, 455,
iast_TELEMETRY_OFF (484.984 µs) : 463, 507
. : milestone, 485,
tracing (444.206 µs) : 424, 465
. : milestone, 444,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.45.0-SNAPSHOT~4cdb964744, baseline=1.45.0-SNAPSHOT~e8df8a0d00
dateFormat X
axisFormat %s
section baseline
no_agent (1.35 ms) : 1330, 1371
. : milestone, 1350,
appsec (1.745 ms) : 1722, 1769
. : milestone, 1745,
appsec_no_iast (1.769 ms) : 1745, 1794
. : milestone, 1769,
iast (1.484 ms) : 1461, 1507
. : milestone, 1484,
profiling (1.526 ms) : 1501, 1550
. : milestone, 1526,
tracing (1.502 ms) : 1477, 1527
. : milestone, 1502,
section candidate
no_agent (1.345 ms) : 1326, 1365
. : milestone, 1345,
appsec (1.742 ms) : 1718, 1766
. : milestone, 1742,
appsec_no_iast (1.765 ms) : 1741, 1790
. : milestone, 1765,
iast (1.489 ms) : 1466, 1512
. : milestone, 1489,
profiling (1.496 ms) : 1472, 1519
. : milestone, 1496,
tracing (1.485 ms) : 1461, 1509
. : milestone, 1485,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.45.0-SNAPSHOT~4cdb964744, baseline=1.45.0-SNAPSHOT~e8df8a0d00
dateFormat X
axisFormat %s
section baseline
no_agent (1.469 ms) : 1458, 1481
. : milestone, 1469,
appsec (2.341 ms) : 2300, 2383
. : milestone, 2341,
iast (2.087 ms) : 2034, 2140
. : milestone, 2087,
iast_GLOBAL (2.137 ms) : 2083, 2190
. : milestone, 2137,
profiling (1.968 ms) : 1926, 2011
. : milestone, 1968,
tracing (1.938 ms) : 1897, 1979
. : milestone, 1938,
section candidate
no_agent (1.47 ms) : 1458, 1481
. : milestone, 1470,
appsec (2.336 ms) : 2294, 2377
. : milestone, 2336,
iast (2.095 ms) : 2042, 2148
. : milestone, 2095,
iast_GLOBAL (2.142 ms) : 2088, 2196
. : milestone, 2142,
profiling (1.948 ms) : 1906, 1990
. : milestone, 1948,
tracing (1.939 ms) : 1898, 1980
. : milestone, 1939,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.45.0-SNAPSHOT~4cdb964744, baseline=1.45.0-SNAPSHOT~e8df8a0d00
dateFormat X
axisFormat %s
section baseline
no_agent (15.44 s) : 15440000, 15440000
. : milestone, 15440000,
appsec (15.154 s) : 15154000, 15154000
. : milestone, 15154000,
iast (18.908 s) : 18908000, 18908000
. : milestone, 18908000,
iast_GLOBAL (17.833 s) : 17833000, 17833000
. : milestone, 17833000,
profiling (15.27 s) : 15270000, 15270000
. : milestone, 15270000,
tracing (14.98 s) : 14980000, 14980000
. : milestone, 14980000,
section candidate
no_agent (15.394 s) : 15394000, 15394000
. : milestone, 15394000,
appsec (15.171 s) : 15171000, 15171000
. : milestone, 15171000,
iast (18.901 s) : 18901000, 18901000
. : milestone, 18901000,
iast_GLOBAL (18.011 s) : 18011000, 18011000
. : milestone, 18011000,
profiling (15.258 s) : 15258000, 15258000
. : milestone, 15258000,
tracing (15.208 s) : 15208000, 15208000
. : milestone, 15208000,
|
What Does This Do
Add the possibility to output the logs of the Java tracer in JSON.
The JSON keys have been chosen to be compatible out of the box with the Logs UI of Datadog.
You will be able to identify all the logs coming from the tracer by filtering them using @origin:dd.trace
Note:
If you don’t configure a specific
datadog.slf4j.simpleLogger.dateTimeFormat
,yyyy-MM-dd'T'HH:mm:ss.SSSZ
to be compatible with the logs UI .[dd.trace 'yyyy-MM-dd HH:mm:ss:SSS Z']
Usage
System property:
datadog.slf4j.simpleLogger.jsonEnabled
Default: false
Description: This configuration key set to true will output the logs of the Java tracer in JSON.
Motivation
#1109
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]