-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuration to Disable APM Tracing #8219
Draft
jandro996
wants to merge
6
commits into
master
Choose a base branch
from
alejandro.gonzalez/Configuration-to-Disable-APM-Tracing
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Configuration to Disable APM Tracing #8219
jandro996
wants to merge
6
commits into
master
from
alejandro.gonzalez/Configuration-to-Disable-APM-Tracing
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 4 unstable metrics.
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.46.0-SNAPSHOT~b32a59e488, baseline=1.46.0-SNAPSHOT~3bbea8564a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.049 s) : 0, 1049426
Total [baseline] (10.419 s) : 0, 10419399
Agent [candidate] (1.035 s) : 0, 1034675
Total [candidate] (10.492 s) : 0, 10491652
section appsec
Agent [baseline] (1.176 s) : 0, 1176474
Total [baseline] (10.725 s) : 0, 10725242
Agent [candidate] (1.175 s) : 0, 1175307
Total [candidate] (10.704 s) : 0, 10703936
section iast
Agent [baseline] (1.163 s) : 0, 1163149
Total [baseline] (10.934 s) : 0, 10933938
Agent [candidate] (1.167 s) : 0, 1166504
Total [candidate] (10.917 s) : 0, 10916665
section profiling
Agent [baseline] (1.256 s) : 0, 1256228
Total [baseline] (10.806 s) : 0, 10806256
Agent [candidate] (1.255 s) : 0, 1254534
Total [candidate] (10.805 s) : 0, 10804978
gantt
title petclinic - break down per module: candidate=1.46.0-SNAPSHOT~b32a59e488, baseline=1.46.0-SNAPSHOT~3bbea8564a
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (723.857 ms) : 0, 723857
BytebuddyAgent [candidate] (714.708 ms) : 0, 714708
GlobalTracer [baseline] (241.433 ms) : 0, 241433
GlobalTracer [candidate] (237.365 ms) : 0, 237365
AppSec [baseline] (55.947 ms) : 0, 55947
AppSec [candidate] (55.552 ms) : 0, 55552
Remote Config [baseline] (727.178 µs) : 0, 727
Remote Config [candidate] (691.894 µs) : 0, 692
Telemetry [baseline] (12.384 ms) : 0, 12384
Telemetry [candidate] (11.37 ms) : 0, 11370
section appsec
BytebuddyAgent [baseline] (730.87 ms) : 0, 730870
BytebuddyAgent [candidate] (730.459 ms) : 0, 730459
GlobalTracer [baseline] (235.867 ms) : 0, 235867
GlobalTracer [candidate] (234.607 ms) : 0, 234607
AppSec [baseline] (175.91 ms) : 0, 175910
AppSec [candidate] (176.366 ms) : 0, 176366
IAST [baseline] (20.023 ms) : 0, 20023
IAST [candidate] (19.404 ms) : 0, 19404
Remote Config [baseline] (661.117 µs) : 0, 661
Remote Config [candidate] (685.168 µs) : 0, 685
Telemetry [baseline] (8.195 ms) : 0, 8195
Telemetry [candidate] (8.48 ms) : 0, 8480
section iast
BytebuddyAgent [baseline] (830.325 ms) : 0, 830325
BytebuddyAgent [candidate] (833.635 ms) : 0, 833635
GlobalTracer [baseline] (228.846 ms) : 0, 228846
GlobalTracer [candidate] (228.528 ms) : 0, 228528
AppSec [baseline] (58.34 ms) : 0, 58340
AppSec [candidate] (58.621 ms) : 0, 58621
IAST [baseline] (21.209 ms) : 0, 21209
IAST [candidate] (21.33 ms) : 0, 21330
Remote Config [baseline] (658.356 µs) : 0, 658
Remote Config [candidate] (651.299 µs) : 0, 651
Telemetry [baseline] (8.84 ms) : 0, 8840
Telemetry [candidate] (8.69 ms) : 0, 8690
section profiling
BytebuddyAgent [baseline] (705.528 ms) : 0, 705528
BytebuddyAgent [candidate] (705.004 ms) : 0, 705004
GlobalTracer [baseline] (348.933 ms) : 0, 348933
GlobalTracer [candidate] (348.042 ms) : 0, 348042
AppSec [baseline] (54.747 ms) : 0, 54747
AppSec [candidate] (54.26 ms) : 0, 54260
Remote Config [baseline] (708.988 µs) : 0, 709
Remote Config [candidate] (671.567 µs) : 0, 672
Telemetry [baseline] (8.776 ms) : 0, 8776
Telemetry [candidate] (8.974 ms) : 0, 8974
ProfilingAgent [baseline] (95.333 ms) : 0, 95333
ProfilingAgent [candidate] (95.499 ms) : 0, 95499
Profiling [baseline] (95.356 ms) : 0, 95356
Profiling [candidate] (95.528 ms) : 0, 95528
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.46.0-SNAPSHOT~b32a59e488, baseline=1.46.0-SNAPSHOT~3bbea8564a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.046 s) : 0, 1045961
Total [baseline] (8.651 s) : 0, 8650865
Agent [candidate] (1.037 s) : 0, 1037465
Total [candidate] (8.636 s) : 0, 8635689
section iast
Agent [baseline] (1.166 s) : 0, 1166029
Total [baseline] (9.184 s) : 0, 9183575
Agent [candidate] (1.174 s) : 0, 1173591
Total [candidate] (9.254 s) : 0, 9253989
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.166 s) : 0, 1165646
Total [baseline] (9.163 s) : 0, 9163194
Agent [candidate] (1.164 s) : 0, 1163854
Total [candidate] (9.16 s) : 0, 9159615
section iast_TELEMETRY_OFF
Agent [baseline] (1.166 s) : 0, 1165763
Total [baseline] (9.214 s) : 0, 9213563
Agent [candidate] (1.162 s) : 0, 1162080
Total [candidate] (9.228 s) : 0, 9228177
gantt
title insecure-bank - break down per module: candidate=1.46.0-SNAPSHOT~b32a59e488, baseline=1.46.0-SNAPSHOT~3bbea8564a
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (720.131 ms) : 0, 720131
BytebuddyAgent [candidate] (715.819 ms) : 0, 715819
GlobalTracer [baseline] (241.752 ms) : 0, 241752
GlobalTracer [candidate] (237.112 ms) : 0, 237112
AppSec [baseline] (56.076 ms) : 0, 56076
AppSec [candidate] (55.211 ms) : 0, 55211
Remote Config [baseline] (726.243 µs) : 0, 726
Remote Config [candidate] (704.108 µs) : 0, 704
Telemetry [baseline] (12.206 ms) : 0, 12206
Telemetry [candidate] (13.524 ms) : 0, 13524
section iast
BytebuddyAgent [baseline] (833.022 ms) : 0, 833022
BytebuddyAgent [candidate] (839.168 ms) : 0, 839168
GlobalTracer [baseline] (229.397 ms) : 0, 229397
GlobalTracer [candidate] (229.912 ms) : 0, 229912
AppSec [baseline] (57.873 ms) : 0, 57873
AppSec [candidate] (58.506 ms) : 0, 58506
IAST [baseline] (21.416 ms) : 0, 21416
IAST [candidate] (21.411 ms) : 0, 21411
Remote Config [baseline] (653.86 µs) : 0, 654
Remote Config [candidate] (657.575 µs) : 0, 658
Telemetry [baseline] (8.604 ms) : 0, 8604
Telemetry [candidate] (8.789 ms) : 0, 8789
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (832.764 ms) : 0, 832764
BytebuddyAgent [candidate] (832.353 ms) : 0, 832353
GlobalTracer [baseline] (229.367 ms) : 0, 229367
GlobalTracer [candidate] (227.814 ms) : 0, 227814
AppSec [baseline] (57.844 ms) : 0, 57844
AppSec [candidate] (58.181 ms) : 0, 58181
IAST [baseline] (21.262 ms) : 0, 21262
IAST [candidate] (21.227 ms) : 0, 21227
Remote Config [baseline] (651.961 µs) : 0, 652
Remote Config [candidate] (632.557 µs) : 0, 633
Telemetry [baseline] (8.76 ms) : 0, 8760
Telemetry [candidate] (8.643 ms) : 0, 8643
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (832.282 ms) : 0, 832282
BytebuddyAgent [candidate] (830.182 ms) : 0, 830182
GlobalTracer [baseline] (230.363 ms) : 0, 230363
GlobalTracer [candidate] (228.413 ms) : 0, 228413
AppSec [baseline] (58.036 ms) : 0, 58036
AppSec [candidate] (58.264 ms) : 0, 58264
IAST [baseline] (20.9 ms) : 0, 20900
IAST [candidate] (20.934 ms) : 0, 20934
Remote Config [baseline] (637.553 µs) : 0, 638
Remote Config [candidate] (651.932 µs) : 0, 652
Telemetry [baseline] (8.513 ms) : 0, 8513
Telemetry [candidate] (8.604 ms) : 0, 8604
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 15 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~b32a59e488, baseline=1.46.0-SNAPSHOT~3bbea8564a
dateFormat X
axisFormat %s
section baseline
no_agent (1.357 ms) : 1337, 1376
. : milestone, 1357,
appsec (1.754 ms) : 1730, 1778
. : milestone, 1754,
appsec_no_iast (1.782 ms) : 1755, 1810
. : milestone, 1782,
iast (1.516 ms) : 1491, 1540
. : milestone, 1516,
profiling (1.574 ms) : 1551, 1598
. : milestone, 1574,
tracing (1.507 ms) : 1482, 1532
. : milestone, 1507,
section candidate
no_agent (1.378 ms) : 1358, 1397
. : milestone, 1378,
appsec (1.771 ms) : 1747, 1796
. : milestone, 1771,
appsec_no_iast (1.746 ms) : 1721, 1770
. : milestone, 1746,
iast (1.511 ms) : 1487, 1536
. : milestone, 1511,
profiling (1.513 ms) : 1490, 1536
. : milestone, 1513,
tracing (1.494 ms) : 1470, 1518
. : milestone, 1494,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~b32a59e488, baseline=1.46.0-SNAPSHOT~3bbea8564a
dateFormat X
axisFormat %s
section baseline
no_agent (392.007 µs) : 372, 412
. : milestone, 392,
iast (520.91 µs) : 499, 543
. : milestone, 521,
iast_FULL (750.34 µs) : 728, 772
. : milestone, 750,
iast_GLOBAL (563.615 µs) : 540, 587
. : milestone, 564,
iast_HARDCODED_SECRET_DISABLED (520.38 µs) : 497, 543
. : milestone, 520,
iast_INACTIVE (467.7 µs) : 446, 489
. : milestone, 468,
iast_TELEMETRY_OFF (502.444 µs) : 481, 524
. : milestone, 502,
tracing (462.145 µs) : 441, 483
. : milestone, 462,
section candidate
no_agent (388.726 µs) : 369, 408
. : milestone, 389,
iast (515.553 µs) : 493, 538
. : milestone, 516,
iast_FULL (749.961 µs) : 726, 774
. : milestone, 750,
iast_GLOBAL (576.453 µs) : 554, 599
. : milestone, 576,
iast_HARDCODED_SECRET_DISABLED (516.595 µs) : 494, 540
. : milestone, 517,
iast_INACTIVE (468.225 µs) : 447, 490
. : milestone, 468,
iast_TELEMETRY_OFF (507.073 µs) : 484, 530
. : milestone, 507,
tracing (467.125 µs) : 446, 489
. : milestone, 467,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~b32a59e488, baseline=1.46.0-SNAPSHOT~3bbea8564a
dateFormat X
axisFormat %s
section baseline
no_agent (1.469 ms) : 1457, 1480
. : milestone, 1469,
appsec (2.362 ms) : 2318, 2406
. : milestone, 2362,
iast (2.107 ms) : 2051, 2162
. : milestone, 2107,
iast_GLOBAL (2.149 ms) : 2093, 2204
. : milestone, 2149,
profiling (1.965 ms) : 1921, 2010
. : milestone, 1965,
tracing (1.95 ms) : 1907, 1992
. : milestone, 1950,
section candidate
no_agent (1.47 ms) : 1458, 1481
. : milestone, 1470,
appsec (2.347 ms) : 2304, 2391
. : milestone, 2347,
iast (2.106 ms) : 2051, 2161
. : milestone, 2106,
iast_GLOBAL (2.153 ms) : 2098, 2209
. : milestone, 2153,
profiling (1.988 ms) : 1943, 2033
. : milestone, 1988,
tracing (1.95 ms) : 1907, 1992
. : milestone, 1950,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~b32a59e488, baseline=1.46.0-SNAPSHOT~3bbea8564a
dateFormat X
axisFormat %s
section baseline
no_agent (15.425 s) : 15425000, 15425000
. : milestone, 15425000,
appsec (15.269 s) : 15269000, 15269000
. : milestone, 15269000,
iast (19.089 s) : 19089000, 19089000
. : milestone, 19089000,
iast_GLOBAL (18.041 s) : 18041000, 18041000
. : milestone, 18041000,
profiling (15.102 s) : 15102000, 15102000
. : milestone, 15102000,
tracing (15.111 s) : 15111000, 15111000
. : milestone, 15111000,
section candidate
no_agent (15.525 s) : 15525000, 15525000
. : milestone, 15525000,
appsec (14.949 s) : 14949000, 14949000
. : milestone, 14949000,
iast (18.34 s) : 18340000, 18340000
. : milestone, 18340000,
iast_GLOBAL (18.219 s) : 18219000, 18219000
. : milestone, 18219000,
profiling (14.974 s) : 14974000, 14974000
. : milestone, 14974000,
tracing (15.07 s) : 15070000, 15070000
. : milestone, 15070000,
|
jandro996
force-pushed
the
alejandro.gonzalez/Configuration-to-Disable-APM-Tracing
branch
from
January 24, 2025 10:19
bfd572e
to
33ce3ad
Compare
Co-authored-by: datadog-datadog-prod-us1[bot] <88084959+datadog-datadog-prod-us1[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
🏗️ WORK IN PROGRESS 👷♂️
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]