Replace UUID.randomUUID() with RandomUtils.randomUUID() #8267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcculls
force-pushed
the
mcculls/avoid-stock-randomUUID
branch
from
6d43df3 to
1e36f12
Compare
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (305.787 µs) : 275, 337
. : milestone, 306,
basic (302.979 µs) : 293, 313
. : milestone, 303,
loop (10.14 ms) : 10105, 10176
. : milestone, 10140,
section candidate
noprobe (314.903 µs) : 277, 353
. : milestone, 315,
basic (306.728 µs) : 298, 316
. : milestone, 307,
loop (10.159 ms) : 10119, 10199
. : milestone, 10159,
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 7 performance improvements and 1 performance regressions! Performance is the same for 51 metrics, 4 unstable metrics.
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.46.0-SNAPSHOT~ee941491a0, baseline=1.46.0-SNAPSHOT~991929d244
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.055 s) : 0, 1055445
Total [baseline] (8.632 s) : 0, 8631642
Agent [candidate] (1.05 s) : 0, 1049774
Total [candidate] (8.69 s) : 0, 8689744
section iast
Agent [baseline] (1.185 s) : 0, 1184575
Total [baseline] (9.218 s) : 0, 9217629
Agent [candidate] (1.171 s) : 0, 1171380
Total [candidate] (9.222 s) : 0, 9222173
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.183 s) : 0, 1183272
Total [baseline] (9.211 s) : 0, 9211277
Agent [candidate] (1.168 s) : 0, 1167526
Total [candidate] (9.19 s) : 0, 9189928
section iast_TELEMETRY_OFF
Agent [baseline] (1.18 s) : 0, 1179830
Total [baseline] (9.201 s) : 0, 9201254
Agent [candidate] (1.18 s) : 0, 1179669
Total [candidate] (9.282 s) : 0, 9281615
gantt
title insecure-bank - break down per module: candidate=1.46.0-SNAPSHOT~ee941491a0, baseline=1.46.0-SNAPSHOT~991929d244
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (713.731 ms) : 0, 713731
BytebuddyAgent [candidate] (724.62 ms) : 0, 724620
GlobalTracer [baseline] (254.959 ms) : 0, 254959
GlobalTracer [candidate] (242.17 ms) : 0, 242170
AppSec [baseline] (55.374 ms) : 0, 55374
AppSec [candidate] (56.128 ms) : 0, 56128
Remote Config [baseline] (741.345 µs) : 0, 741
Remote Config [candidate] (733.384 µs) : 0, 733
Telemetry [baseline] (15.681 ms) : 0, 15681
Telemetry [candidate] (10.89 ms) : 0, 10890
section iast
BytebuddyAgent [baseline] (833.307 ms) : 0, 833307
BytebuddyAgent [candidate] (835.978 ms) : 0, 835978
GlobalTracer [baseline] (246.905 ms) : 0, 246905
GlobalTracer [candidate] (230.718 ms) : 0, 230718
AppSec [baseline] (58.42 ms) : 0, 58420
AppSec [candidate] (58.671 ms) : 0, 58671
Remote Config [baseline] (674.476 µs) : 0, 674
Remote Config [candidate] (664.952 µs) : 0, 665
Telemetry [baseline] (8.806 ms) : 0, 8806
Telemetry [candidate] (8.776 ms) : 0, 8776
IAST [baseline] (21.456 ms) : 0, 21456
IAST [candidate] (21.437 ms) : 0, 21437
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (832.768 ms) : 0, 832768
BytebuddyAgent [candidate] (833.481 ms) : 0, 833481
GlobalTracer [baseline] (246.285 ms) : 0, 246285
GlobalTracer [candidate] (229.472 ms) : 0, 229472
AppSec [baseline] (58.227 ms) : 0, 58227
AppSec [candidate] (58.441 ms) : 0, 58441
Remote Config [baseline] (682.709 µs) : 0, 683
Remote Config [candidate] (677.615 µs) : 0, 678
Telemetry [baseline] (8.793 ms) : 0, 8793
Telemetry [candidate] (8.831 ms) : 0, 8831
IAST [baseline] (21.463 ms) : 0, 21463
IAST [candidate] (21.535 ms) : 0, 21535
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (830.676 ms) : 0, 830676
BytebuddyAgent [candidate] (843.131 ms) : 0, 843131
GlobalTracer [baseline] (246.078 ms) : 0, 246078
GlobalTracer [candidate] (231.971 ms) : 0, 231971
AppSec [baseline] (57.902 ms) : 0, 57902
AppSec [candidate] (58.504 ms) : 0, 58504
Remote Config [baseline] (669.639 µs) : 0, 670
Remote Config [candidate] (657.642 µs) : 0, 658
Telemetry [baseline] (8.687 ms) : 0, 8687
Telemetry [candidate] (8.815 ms) : 0, 8815
IAST [baseline] (20.811 ms) : 0, 20811
IAST [candidate] (21.324 ms) : 0, 21324
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.46.0-SNAPSHOT~ee941491a0, baseline=1.46.0-SNAPSHOT~991929d244
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.056 s) : 0, 1056474
Total [baseline] (10.416 s) : 0, 10416080
Agent [candidate] (1.049 s) : 0, 1048855
Total [candidate] (10.511 s) : 0, 10510576
section appsec
Agent [baseline] (1.189 s) : 0, 1189005
Total [baseline] (10.759 s) : 0, 10759150
Agent [candidate] (1.184 s) : 0, 1184156
Total [candidate] (10.788 s) : 0, 10787673
section iast
Agent [baseline] (1.184 s) : 0, 1184318
Total [baseline] (10.98 s) : 0, 10979594
Agent [candidate] (1.184 s) : 0, 1184298
Total [candidate] (11.015 s) : 0, 11015230
section profiling
Agent [baseline] (1.255 s) : 0, 1254852
Total [baseline] (10.92 s) : 0, 10920005
Agent [candidate] (1.258 s) : 0, 1258039
Total [candidate] (10.829 s) : 0, 10829345
gantt
title petclinic - break down per module: candidate=1.46.0-SNAPSHOT~ee941491a0, baseline=1.46.0-SNAPSHOT~991929d244
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (715.695 ms) : 0, 715695
BytebuddyAgent [candidate] (722.68 ms) : 0, 722680
GlobalTracer [baseline] (255.82 ms) : 0, 255820
GlobalTracer [candidate] (241.208 ms) : 0, 241208
AppSec [baseline] (57.162 ms) : 0, 57162
AppSec [candidate] (56.015 ms) : 0, 56015
Remote Config [baseline] (740.058 µs) : 0, 740
Remote Config [candidate] (724.92 µs) : 0, 725
Telemetry [baseline] (12.129 ms) : 0, 12129
Telemetry [candidate] (13.012 ms) : 0, 13012
section appsec
BytebuddyAgent [baseline] (731.7 ms) : 0, 731700
BytebuddyAgent [candidate] (736.034 ms) : 0, 736034
GlobalTracer [baseline] (252.506 ms) : 0, 252506
GlobalTracer [candidate] (237.959 ms) : 0, 237959
AppSec [baseline] (170.955 ms) : 0, 170955
AppSec [candidate] (176.237 ms) : 0, 176237
Remote Config [baseline] (666.001 µs) : 0, 666
Remote Config [candidate] (669.064 µs) : 0, 669
Telemetry [baseline] (8.537 ms) : 0, 8537
Telemetry [candidate] (8.577 ms) : 0, 8577
IAST [baseline] (19.298 ms) : 0, 19298
IAST [candidate] (19.222 ms) : 0, 19222
section iast
BytebuddyAgent [baseline] (833.046 ms) : 0, 833046
BytebuddyAgent [candidate] (847.638 ms) : 0, 847638
GlobalTracer [baseline] (246.832 ms) : 0, 246832
GlobalTracer [candidate] (231.418 ms) : 0, 231418
AppSec [baseline] (58.335 ms) : 0, 58335
AppSec [candidate] (58.868 ms) : 0, 58868
Remote Config [baseline] (676.612 µs) : 0, 677
Remote Config [candidate] (664.152 µs) : 0, 664
Telemetry [baseline] (8.787 ms) : 0, 8787
Telemetry [candidate] (8.917 ms) : 0, 8917
IAST [baseline] (21.598 ms) : 0, 21598
IAST [candidate] (21.526 ms) : 0, 21526
section profiling
BytebuddyAgent [baseline] (702.698 ms) : 0, 702698
BytebuddyAgent [candidate] (707.866 ms) : 0, 707866
GlobalTracer [baseline] (348.709 ms) : 0, 348709
GlobalTracer [candidate] (349.229 ms) : 0, 349229
AppSec [baseline] (55.547 ms) : 0, 55547
AppSec [candidate] (53.973 ms) : 0, 53973
Remote Config [baseline] (732.32 µs) : 0, 732
Remote Config [candidate] (720.802 µs) : 0, 721
Telemetry [baseline] (8.848 ms) : 0, 8848
Telemetry [candidate] (8.74 ms) : 0, 8740
ProfilingAgent [baseline] (96.317 ms) : 0, 96317
ProfilingAgent [candidate] (95.188 ms) : 0, 95188
Profiling [baseline] (96.342 ms) : 0, 96342
Profiling [candidate] (95.212 ms) : 0, 95212
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~ee941491a0, baseline=1.46.0-SNAPSHOT~991929d244
dateFormat X
axisFormat %s
section baseline
no_agent (379.872 µs) : 360, 399
. : milestone, 380,
iast (503.956 µs) : 482, 526
. : milestone, 504,
iast_FULL (745.583 µs) : 723, 768
. : milestone, 746,
iast_GLOBAL (557.562 µs) : 535, 580
. : milestone, 558,
iast_HARDCODED_SECRET_DISABLED (510.489 µs) : 489, 532
. : milestone, 510,
iast_INACTIVE (455.665 µs) : 434, 477
. : milestone, 456,
iast_TELEMETRY_OFF (493.219 µs) : 472, 515
. : milestone, 493,
tracing (458.04 µs) : 437, 479
. : milestone, 458,
section candidate
no_agent (381.437 µs) : 360, 403
. : milestone, 381,
iast (508.145 µs) : 485, 532
. : milestone, 508,
iast_FULL (747.117 µs) : 725, 769
. : milestone, 747,
iast_GLOBAL (558.549 µs) : 535, 583
. : milestone, 559,
iast_HARDCODED_SECRET_DISABLED (511.008 µs) : 489, 533
. : milestone, 511,
iast_INACTIVE (455.898 µs) : 435, 477
. : milestone, 456,
iast_TELEMETRY_OFF (500.521 µs) : 477, 524
. : milestone, 501,
tracing (455.757 µs) : 435, 477
. : milestone, 456,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~ee941491a0, baseline=1.46.0-SNAPSHOT~991929d244
dateFormat X
axisFormat %s
section baseline
no_agent (1.37 ms) : 1351, 1390
. : milestone, 1370,
appsec (1.74 ms) : 1716, 1764
. : milestone, 1740,
appsec_no_iast (1.742 ms) : 1717, 1768
. : milestone, 1742,
iast (1.5 ms) : 1475, 1524
. : milestone, 1500,
profiling (1.51 ms) : 1486, 1534
. : milestone, 1510,
tracing (1.487 ms) : 1462, 1512
. : milestone, 1487,
section candidate
no_agent (1.347 ms) : 1327, 1367
. : milestone, 1347,
appsec (1.75 ms) : 1728, 1773
. : milestone, 1750,
appsec_no_iast (1.741 ms) : 1716, 1766
. : milestone, 1741,
iast (1.512 ms) : 1487, 1536
. : milestone, 1512,
profiling (1.535 ms) : 1511, 1560
. : milestone, 1535,
tracing (1.481 ms) : 1456, 1506
. : milestone, 1481,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~ee941491a0, baseline=1.46.0-SNAPSHOT~991929d244
dateFormat X
axisFormat %s
section baseline
no_agent (1.47 ms) : 1458, 1481
. : milestone, 1470,
appsec (2.37 ms) : 2327, 2414
. : milestone, 2370,
iast (2.102 ms) : 2048, 2157
. : milestone, 2102,
iast_GLOBAL (2.158 ms) : 2103, 2213
. : milestone, 2158,
profiling (2.469 ms) : 2277, 2661
. : milestone, 2469,
tracing (1.954 ms) : 1912, 1997
. : milestone, 1954,
section candidate
no_agent (1.474 ms) : 1462, 1486
. : milestone, 1474,
appsec (2.371 ms) : 2328, 2414
. : milestone, 2371,
iast (2.103 ms) : 2048, 2157
. : milestone, 2103,
iast_GLOBAL (2.157 ms) : 2102, 2212
. : milestone, 2157,
profiling (1.965 ms) : 1921, 2008
. : milestone, 1965,
tracing (1.951 ms) : 1909, 1993
. : milestone, 1951,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~ee941491a0, baseline=1.46.0-SNAPSHOT~991929d244
dateFormat X
axisFormat %s
section baseline
no_agent (15.495 s) : 15495000, 15495000
. : milestone, 15495000,
appsec (14.812 s) : 14812000, 14812000
. : milestone, 14812000,
iast (19.214 s) : 19214000, 19214000
. : milestone, 19214000,
iast_GLOBAL (18.199 s) : 18199000, 18199000
. : milestone, 18199000,
profiling (14.945 s) : 14945000, 14945000
. : milestone, 14945000,
tracing (15.317 s) : 15317000, 15317000
. : milestone, 15317000,
section candidate
no_agent (14.93 s) : 14930000, 14930000
. : milestone, 14930000,
appsec (15.073 s) : 15073000, 15073000
. : milestone, 15073000,
iast (18.385 s) : 18385000, 18385000
. : milestone, 18385000,
iast_GLOBAL (18.257 s) : 18257000, 18257000
. : milestone, 18257000,
profiling (15.07 s) : 15070000, 15070000
. : milestone, 15070000,
tracing (14.866 s) : 14866000, 14866000
. : milestone, 14866000,
|
mcculls
requested review from
jandro996,
sezen-datadog,
ojung,
nikita-tkachenko-datadog,
manuel-alvarez-alvarez,
dougqh and
PerfectSlayer
and removed request for
a team
|
I'd appreciate @dougqh's and @PerfectSlayer's thoughts on the implications of using |
There was a problem hiding this comment.
According UUID.randomUUID() documentation:
The UUID is generated using a cryptographically strong pseudo random number generator.
So I would be en favor of keeping strong cryptography as forbidden API plugin will discourage devs using the original strong one.
But It doesn’t prevent us to create a weak cryptography alternative with a dedicated name and use it where it makes sense.
Out of interest do you know of a case where we'd need a strong cryptographically random UUID - the only places I've found just need uniqueness? Given we know that using |
PerfectSlayer
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
do you know of a case where we'd need a strong cryptographically random UUID
No, I don’t. My recommendation was only to make sure we provide a way to avoid any future issue when such case arrive -- not having a build error for using a strong one and only leaving a weak alternative.
So we should be good with our current code base 😉
mcculls
force-pushed
the
mcculls/avoid-stock-randomUUID
branch
from
1e36f12 to
8e1f775
Compare
|
No problem, that's a fair point: 8e1f775 |
mcculls
force-pushed
the
mcculls/avoid-stock-randomUUID
branch
2 times, most recently
from
7bbe53b to
582febc
Compare
mcculls
added
tag: no release notes
This avoids a potential side-effect of loading 'java.util.logging' too early when the Amazon Corretto Crypto Provider (ACCP) is plugged into SecureRandom
mcculls
force-pushed
the
mcculls/avoid-stock-randomUUID
branch
from
582febc to
ee94149
Compare
mcculls
added
tag: no release notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This avoids a potential side-effect of loading
java.util.loggingtoo early when the Amazon Corretto Crypto Provider (ACCP) is plugged intoSecureRandomContributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: APMS-14233