Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly finish spans and support latest apache httpclient5 #8272

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Properly finish spans and support latest apache httpclient5 #8272

merged 2 commits into from
Jan 23, 2025

Conversation

amarziali
Copy link
Collaborator

What Does This Do

Re-enable testing of latestDep for the async client case. In fact, because all those tests was forked, we were not executing them on the latestDep since there was no declaration of latestDepForkedTest
Instead adding a task we can run not forked the V0 naming test cases since they do not need to run forked. There is no need to run the v1 naming test on the latestDep since the naming is not depending to the version we're testing.

Running the tests I observed that the async test cases were timeouting because the spans was never finished. In fact, extractResponseFromContext was not protecting the context object access with a null check. The latest versions of http client 5 seems not to provide a context. However the future contains the response that can be used. That fix mitigate this issue

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@amarziali amarziali requested a review from a team as a code owner January 23, 2025 10:10
@amarziali amarziali force-pushed the andrea.marziali/httpclient5 branch from df75e8e to 4c3504a Compare January 23, 2025 10:15
PerfectSlayer
PerfectSlayer approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amarziali amarziali enabled auto-merge (squash) January 23, 2025 10:21
@pr-commenter
Copy link

pr-commenter bot commented Jan 23, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/httpclient5
git_commit_date 1737627954 1737630330
git_commit_sha 1efc71f 3888c68
release_version 1.46.0-SNAPSHOT~1efc71f4a0 1.46.0-SNAPSHOT~3888c681ef
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1737632730 1737632730
ci_job_id 777446338 777446338
ci_pipeline_id 53782532 53782532
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 6 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.46.0-SNAPSHOT~3888c681ef, baseline=1.46.0-SNAPSHOT~1efc71f4a0

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.057 s) : 0, 1057422
Total [baseline] (10.432 s) : 0, 10431803
Agent [candidate] (1.059 s) : 0, 1059238
Total [candidate] (10.577 s) : 0, 10576720
section appsec
Agent [baseline] (1.189 s) : 0, 1188795
Total [baseline] (10.769 s) : 0, 10768543
Agent [candidate] (1.192 s) : 0, 1191914
Total [candidate] (10.746 s) : 0, 10745769
section iast
Agent [baseline] (1.191 s) : 0, 1191151
Total [baseline] (10.954 s) : 0, 10954316
Agent [candidate] (1.185 s) : 0, 1185048
Total [candidate] (11.037 s) : 0, 11036987
section profiling
Agent [baseline] (1.263 s) : 0, 1262693
Total [baseline] (10.946 s) : 0, 10946255
Agent [candidate] (1.257 s) : 0, 1257002
Total [candidate] (10.85 s) : 0, 10849654
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.057 s -
Agent appsec 1.189 s 131.373 ms (12.4%)
Agent iast 1.191 s 133.729 ms (12.6%)
Agent profiling 1.263 s 205.271 ms (19.4%)
Total tracing 10.432 s -
Total appsec 10.769 s 336.74 ms (3.2%)
Total iast 10.954 s 522.513 ms (5.0%)
Total profiling 10.946 s 514.452 ms (4.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.059 s -
Agent appsec 1.192 s 132.676 ms (12.5%)
Agent iast 1.185 s 125.81 ms (11.9%)
Agent profiling 1.257 s 197.764 ms (18.7%)
Total tracing 10.577 s -
Total appsec 10.746 s 169.049 ms (1.6%)
Total iast 11.037 s 460.267 ms (4.4%)
Total profiling 10.85 s 272.934 ms (2.6%) 
gantt
    title petclinic - break down per module: candidate=1.46.0-SNAPSHOT~3888c681ef, baseline=1.46.0-SNAPSHOT~1efc71f4a0

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (714.979 ms) : 0, 714979
BytebuddyAgent [candidate] (715.803 ms) : 0, 715803
GlobalTracer [baseline] (255.794 ms) : 0, 255794
GlobalTracer [candidate] (256.127 ms) : 0, 256127
AppSec [baseline] (55.982 ms) : 0, 55982
AppSec [candidate] (55.724 ms) : 0, 55724
Remote Config [baseline] (736.634 µs) : 0, 737
Remote Config [candidate] (767.137 µs) : 0, 767
Telemetry [baseline] (14.882 ms) : 0, 14882
Telemetry [candidate] (15.705 ms) : 0, 15705
section appsec
BytebuddyAgent [baseline] (731.452 ms) : 0, 731452
BytebuddyAgent [candidate] (733.883 ms) : 0, 733883
GlobalTracer [baseline] (252.881 ms) : 0, 252881
GlobalTracer [candidate] (253.33 ms) : 0, 253330
AppSec [baseline] (170.593 ms) : 0, 170593
AppSec [candidate] (171.103 ms) : 0, 171103
Remote Config [baseline] (669.581 µs) : 0, 670
Remote Config [candidate] (658.909 µs) : 0, 659
Telemetry [baseline] (8.558 ms) : 0, 8558
Telemetry [candidate] (8.197 ms) : 0, 8197
IAST [baseline] (19.436 ms) : 0, 19436
IAST [candidate] (19.387 ms) : 0, 19387
section iast
BytebuddyAgent [baseline] (839.827 ms) : 0, 839827
BytebuddyAgent [candidate] (833.406 ms) : 0, 833406
GlobalTracer [baseline] (247.263 ms) : 0, 247263
GlobalTracer [candidate] (247.601 ms) : 0, 247601
AppSec [baseline] (57.978 ms) : 0, 57978
AppSec [candidate] (58.049 ms) : 0, 58049
Remote Config [baseline] (670.712 µs) : 0, 671
Remote Config [candidate] (672.145 µs) : 0, 672
Telemetry [baseline] (8.668 ms) : 0, 8668
Telemetry [candidate] (8.826 ms) : 0, 8826
IAST [baseline] (21.57 ms) : 0, 21570
IAST [candidate] (21.489 ms) : 0, 21489
section profiling
ProfilingAgent [baseline] (96.439 ms) : 0, 96439
ProfilingAgent [candidate] (95.497 ms) : 0, 95497
BytebuddyAgent [baseline] (708.409 ms) : 0, 708409
BytebuddyAgent [candidate] (705.738 ms) : 0, 705738
GlobalTracer [baseline] (350.922 ms) : 0, 350922
GlobalTracer [candidate] (350.076 ms) : 0, 350076
AppSec [baseline] (55.164 ms) : 0, 55164
AppSec [candidate] (54.038 ms) : 0, 54038
Remote Config [baseline] (724.999 µs) : 0, 725
Remote Config [candidate] (726.407 µs) : 0, 726
Telemetry [baseline] (8.765 ms) : 0, 8765
Telemetry [candidate] (8.769 ms) : 0, 8769
Profiling [baseline] (96.463 ms) : 0, 96463
Profiling [candidate] (95.522 ms) : 0, 95522
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.46.0-SNAPSHOT~3888c681ef, baseline=1.46.0-SNAPSHOT~1efc71f4a0

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.058 s) : 0, 1058277
Total [baseline] (8.635 s) : 0, 8635080
Agent [candidate] (1.07 s) : 0, 1069858
Total [candidate] (8.653 s) : 0, 8653149
section iast
Agent [baseline] (1.195 s) : 0, 1195228
Total [baseline] (9.256 s) : 0, 9256014
Agent [candidate] (1.19 s) : 0, 1190498
Total [candidate] (9.206 s) : 0, 9205891
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.186 s) : 0, 1185523
Total [baseline] (9.189 s) : 0, 9188828
Agent [candidate] (1.194 s) : 0, 1194320
Total [candidate] (9.234 s) : 0, 9233721
section iast_TELEMETRY_OFF
Agent [baseline] (1.178 s) : 0, 1178134
Total [baseline] (9.204 s) : 0, 9203758
Agent [candidate] (1.186 s) : 0, 1186274
Total [candidate] (9.267 s) : 0, 9267189
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.058 s -
Agent iast 1.195 s 136.951 ms (12.9%)
Agent iast_HARDCODED_SECRET_DISABLED 1.186 s 127.246 ms (12.0%)
Agent iast_TELEMETRY_OFF 1.178 s 119.857 ms (11.3%)
Total tracing 8.635 s -
Total iast 9.256 s 620.934 ms (7.2%)
Total iast_HARDCODED_SECRET_DISABLED 9.189 s 553.747 ms (6.4%)
Total iast_TELEMETRY_OFF 9.204 s 568.678 ms (6.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.07 s -
Agent iast 1.19 s 120.64 ms (11.3%)
Agent iast_HARDCODED_SECRET_DISABLED 1.194 s 124.462 ms (11.6%)
Agent iast_TELEMETRY_OFF 1.186 s 116.416 ms (10.9%)
Total tracing 8.653 s -
Total iast 9.206 s 552.742 ms (6.4%)
Total iast_HARDCODED_SECRET_DISABLED 9.234 s 580.571 ms (6.7%)
Total iast_TELEMETRY_OFF 9.267 s 614.04 ms (7.1%) 
gantt
    title insecure-bank - break down per module: candidate=1.46.0-SNAPSHOT~3888c681ef, baseline=1.46.0-SNAPSHOT~1efc71f4a0

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (716.468 ms) : 0, 716468
BytebuddyAgent [candidate] (724.713 ms) : 0, 724713
GlobalTracer [baseline] (255.028 ms) : 0, 255028
GlobalTracer [candidate] (258.941 ms) : 0, 258941
AppSec [baseline] (55.48 ms) : 0, 55480
AppSec [candidate] (56.738 ms) : 0, 56738
Remote Config [baseline] (731.866 µs) : 0, 732
Remote Config [candidate] (748.095 µs) : 0, 748
Telemetry [baseline] (15.601 ms) : 0, 15601
Telemetry [candidate] (13.526 ms) : 0, 13526
section iast
BytebuddyAgent [baseline] (840.612 ms) : 0, 840612
BytebuddyAgent [candidate] (837.893 ms) : 0, 837893
GlobalTracer [baseline] (249.117 ms) : 0, 249117
GlobalTracer [candidate] (248.3 ms) : 0, 248300
AppSec [baseline] (58.9 ms) : 0, 58900
AppSec [candidate] (58.254 ms) : 0, 58254
Remote Config [baseline] (672.22 µs) : 0, 672
Remote Config [candidate] (664.834 µs) : 0, 665
Telemetry [baseline] (8.82 ms) : 0, 8820
Telemetry [candidate] (8.782 ms) : 0, 8782
IAST [baseline] (21.9 ms) : 0, 21900
IAST [candidate] (21.476 ms) : 0, 21476
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (834.545 ms) : 0, 834545
BytebuddyAgent [candidate] (840.916 ms) : 0, 840916
GlobalTracer [baseline] (246.445 ms) : 0, 246445
GlobalTracer [candidate] (248.761 ms) : 0, 248761
AppSec [baseline] (58.39 ms) : 0, 58390
AppSec [candidate] (58.359 ms) : 0, 58359
Remote Config [baseline] (673.266 µs) : 0, 673
Remote Config [candidate] (665.673 µs) : 0, 666
Telemetry [baseline] (8.821 ms) : 0, 8821
Telemetry [candidate] (8.861 ms) : 0, 8861
IAST [baseline] (21.686 ms) : 0, 21686
IAST [candidate] (21.559 ms) : 0, 21559
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (828.807 ms) : 0, 828807
BytebuddyAgent [candidate] (834.408 ms) : 0, 834408
GlobalTracer [baseline] (245.959 ms) : 0, 245959
GlobalTracer [candidate] (247.558 ms) : 0, 247558
AppSec [baseline] (57.973 ms) : 0, 57973
AppSec [candidate] (58.496 ms) : 0, 58496
Remote Config [baseline] (675.359 µs) : 0, 675
Remote Config [candidate] (683.552 µs) : 0, 684
Telemetry [baseline] (8.654 ms) : 0, 8654
Telemetry [candidate] (8.741 ms) : 0, 8741
IAST [baseline] (21.052 ms) : 0, 21052
IAST [candidate] (21.294 ms) : 0, 21294
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-01-23T11:17:52 2025-01-23T11:24:59
git_branch master andrea.marziali/httpclient5
git_commit_date 1737627954 1737630330
git_commit_sha 1efc71f 3888c68
release_version 1.46.0-SNAPSHOT~1efc71f4a0 1.46.0-SNAPSHOT~3888c681ef
start_time 2025-01-23T11:17:38 2025-01-23T11:24:45
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1737631859 1737631859
ci_job_id 777446339 777446339
ci_pipeline_id 53782532 53782532
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~3888c681ef, baseline=1.46.0-SNAPSHOT~1efc71f4a0
    dateFormat X
    axisFormat %s
section baseline
no_agent (381.518 µs) : 362, 401
.   : milestone, 382,
iast (513.8 µs) : 492, 536
.   : milestone, 514,
iast_FULL (751.693 µs) : 730, 774
.   : milestone, 752,
iast_GLOBAL (556.929 µs) : 534, 579
.   : milestone, 557,
iast_HARDCODED_SECRET_DISABLED (510.516 µs) : 489, 532
.   : milestone, 511,
iast_INACTIVE (462.414 µs) : 441, 484
.   : milestone, 462,
iast_TELEMETRY_OFF (500.39 µs) : 479, 522
.   : milestone, 500,
tracing (460.014 µs) : 439, 481
.   : milestone, 460,
section candidate
no_agent (384.12 µs) : 364, 404
.   : milestone, 384,
iast (512.161 µs) : 490, 534
.   : milestone, 512,
iast_FULL (747.618 µs) : 726, 769
.   : milestone, 748,
iast_GLOBAL (560.51 µs) : 538, 583
.   : milestone, 561,
iast_HARDCODED_SECRET_DISABLED (512.385 µs) : 490, 534
.   : milestone, 512,
iast_INACTIVE (461.833 µs) : 441, 483
.   : milestone, 462,
iast_TELEMETRY_OFF (502.054 µs) : 480, 524
.   : milestone, 502,
tracing (454.341 µs) : 433, 476
.   : milestone, 454,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 381.518 µs [361.831 µs, 401.205 µs] -
iast 513.8 µs [491.945 µs, 535.655 µs] 132.283 µs (34.7%)
iast_FULL 751.693 µs [729.784 µs, 773.601 µs] 370.175 µs (97.0%)
iast_GLOBAL 556.929 µs [534.444 µs, 579.413 µs] 175.411 µs (46.0%)
iast_HARDCODED_SECRET_DISABLED 510.516 µs [489.027 µs, 532.005 µs] 128.998 µs (33.8%)
iast_INACTIVE 462.414 µs [440.976 µs, 483.853 µs] 80.897 µs (21.2%)
iast_TELEMETRY_OFF 500.39 µs [478.733 µs, 522.047 µs] 118.872 µs (31.2%)
tracing 460.014 µs [439.206 µs, 480.823 µs] 78.497 µs (20.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 384.12 µs [363.759 µs, 404.48 µs] -
iast 512.161 µs [490.284 µs, 534.039 µs] 128.042 µs (33.3%)
iast_FULL 747.618 µs [725.9 µs, 769.336 µs] 363.499 µs (94.6%)
iast_GLOBAL 560.51 µs [538.423 µs, 582.597 µs] 176.39 µs (45.9%)
iast_HARDCODED_SECRET_DISABLED 512.385 µs [490.271 µs, 534.5 µs] 128.266 µs (33.4%)
iast_INACTIVE 461.833 µs [440.591 µs, 483.075 µs] 77.714 µs (20.2%)
iast_TELEMETRY_OFF 502.054 µs [479.686 µs, 524.421 µs] 117.934 µs (30.7%)
tracing 454.341 µs [432.972 µs, 475.71 µs] 70.221 µs (18.3%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~3888c681ef, baseline=1.46.0-SNAPSHOT~1efc71f4a0
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.377 ms) : 1357, 1398
.   : milestone, 1377,
appsec (1.758 ms) : 1734, 1782
.   : milestone, 1758,
appsec_no_iast (1.75 ms) : 1725, 1775
.   : milestone, 1750,
iast (1.532 ms) : 1508, 1555
.   : milestone, 1532,
profiling (1.557 ms) : 1532, 1583
.   : milestone, 1557,
tracing (1.497 ms) : 1471, 1522
.   : milestone, 1497,
section candidate
no_agent (1.362 ms) : 1343, 1381
.   : milestone, 1362,
appsec (1.757 ms) : 1734, 1781
.   : milestone, 1757,
appsec_no_iast (1.791 ms) : 1767, 1816
.   : milestone, 1791,
iast (1.524 ms) : 1499, 1548
.   : milestone, 1524,
profiling (1.517 ms) : 1494, 1541
.   : milestone, 1517,
tracing (1.502 ms) : 1477, 1527
.   : milestone, 1502,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.377 ms [1.357 ms, 1.398 ms] -
appsec 1.758 ms [1.734 ms, 1.782 ms] 380.932 µs (27.7%)
appsec_no_iast 1.75 ms [1.725 ms, 1.775 ms] 372.55 µs (27.0%)
iast 1.532 ms [1.508 ms, 1.555 ms] 154.086 µs (11.2%)
profiling 1.557 ms [1.532 ms, 1.583 ms] 179.923 µs (13.1%)
tracing 1.497 ms [1.471 ms, 1.522 ms] 119.188 µs (8.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.362 ms [1.343 ms, 1.381 ms] -
appsec 1.757 ms [1.734 ms, 1.781 ms] 395.304 µs (29.0%)
appsec_no_iast 1.791 ms [1.767 ms, 1.816 ms] 429.257 µs (31.5%)
iast 1.524 ms [1.499 ms, 1.548 ms] 161.587 µs (11.9%)
profiling 1.517 ms [1.494 ms, 1.541 ms] 155.201 µs (11.4%)
tracing 1.502 ms [1.477 ms, 1.527 ms] 140.199 µs (10.3%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/httpclient5
git_commit_date 1737627954 1737630330
git_commit_sha 1efc71f 3888c68
release_version 1.46.0-SNAPSHOT~1efc71f4a0 1.46.0-SNAPSHOT~3888c681ef
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1737632410 1737632410
ci_job_id 777446340 777446340
ci_pipeline_id 53782532 53782532
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~3888c681ef, baseline=1.46.0-SNAPSHOT~1efc71f4a0
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.574 s) : 15574000, 15574000
.   : milestone, 15574000,
appsec (14.997 s) : 14997000, 14997000
.   : milestone, 14997000,
iast (19.082 s) : 19082000, 19082000
.   : milestone, 19082000,
iast_GLOBAL (18.229 s) : 18229000, 18229000
.   : milestone, 18229000,
profiling (15.275 s) : 15275000, 15275000
.   : milestone, 15275000,
tracing (14.86 s) : 14860000, 14860000
.   : milestone, 14860000,
section candidate
no_agent (15.488 s) : 15488000, 15488000
.   : milestone, 15488000,
appsec (15.267 s) : 15267000, 15267000
.   : milestone, 15267000,
iast (18.75 s) : 18750000, 18750000
.   : milestone, 18750000,
iast_GLOBAL (17.753 s) : 17753000, 17753000
.   : milestone, 17753000,
profiling (15.066 s) : 15066000, 15066000
.   : milestone, 15066000,
tracing (14.784 s) : 14784000, 14784000
.   : milestone, 14784000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.574 s [15.574 s, 15.574 s] -
appsec 14.997 s [14.997 s, 14.997 s] -577.0 ms (-3.7%)
iast 19.082 s [19.082 s, 19.082 s] 3.508 s (22.5%)
iast_GLOBAL 18.229 s [18.229 s, 18.229 s] 2.655 s (17.0%)
profiling 15.275 s [15.275 s, 15.275 s] -299.0 ms (-1.9%)
tracing 14.86 s [14.86 s, 14.86 s] -714.0 ms (-4.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.488 s [15.488 s, 15.488 s] -
appsec 15.267 s [15.267 s, 15.267 s] -221.0 ms (-1.4%)
iast 18.75 s [18.75 s, 18.75 s] 3.262 s (21.1%)
iast_GLOBAL 17.753 s [17.753 s, 17.753 s] 2.265 s (14.6%)
profiling 15.066 s [15.066 s, 15.066 s] -422.0 ms (-2.7%)
tracing 14.784 s [14.784 s, 14.784 s] -704.0 ms (-4.5%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~3888c681ef, baseline=1.46.0-SNAPSHOT~1efc71f4a0
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.475 ms) : 1463, 1486
.   : milestone, 1475,
appsec (2.372 ms) : 2329, 2415
.   : milestone, 2372,
iast (2.112 ms) : 2057, 2166
.   : milestone, 2112,
iast_GLOBAL (2.156 ms) : 2101, 2211
.   : milestone, 2156,
profiling (1.983 ms) : 1938, 2028
.   : milestone, 1983,
tracing (1.956 ms) : 1914, 1998
.   : milestone, 1956,
section candidate
no_agent (1.479 ms) : 1467, 1490
.   : milestone, 1479,
appsec (2.361 ms) : 2318, 2404
.   : milestone, 2361,
iast (2.111 ms) : 2057, 2166
.   : milestone, 2111,
iast_GLOBAL (2.16 ms) : 2105, 2215
.   : milestone, 2160,
profiling (1.971 ms) : 1928, 2014
.   : milestone, 1971,
tracing (1.947 ms) : 1905, 1989
.   : milestone, 1947,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.475 ms [1.463 ms, 1.486 ms] -
appsec 2.372 ms [2.329 ms, 2.415 ms] 897.469 µs (60.8%)
iast 2.112 ms [2.057 ms, 2.166 ms] 636.718 µs (43.2%)
iast_GLOBAL 2.156 ms [2.101 ms, 2.211 ms] 681.216 µs (46.2%)
profiling 1.983 ms [1.938 ms, 2.028 ms] 508.205 µs (34.5%)
tracing 1.956 ms [1.914 ms, 1.998 ms] 480.867 µs (32.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.479 ms [1.467 ms, 1.49 ms] -
appsec 2.361 ms [2.318 ms, 2.404 ms] 882.45 µs (59.7%)
iast 2.111 ms [2.057 ms, 2.166 ms] 632.186 µs (42.7%)
iast_GLOBAL 2.16 ms [2.105 ms, 2.215 ms] 681.331 µs (46.1%)
profiling 1.971 ms [1.928 ms, 2.014 ms] 492.199 µs (33.3%)
tracing 1.947 ms [1.905 ms, 1.989 ms] 468.246 µs (31.7%)

@amarziali amarziali added comp: api Tracer public API and removed comp: api Tracer public API labels Jan 23, 2025
@amarziali amarziali merged commit 1c3f140 into master Jan 23, 2025
172 of 175 checks passed
@amarziali amarziali deleted the andrea.marziali/httpclient5 branch January 23, 2025 12:09
@github-actions github-actions bot added this to the 1.46.0 milestone Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

Assignees
No one assigned
Labels
inst: apache httpcomponents Apache HttpComponents type: bug
Projects
None yet
Milestone
1.46.0
Development

Successfully merging this pull request may close these issues.
2 participants
@amarziali @PerfectSlayer