-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update metrics: appsec.waf.updates and appsec.waf.init #8280
Draft
Mariovido
wants to merge
1
commit into
master
Choose a base branch
from
mario.vidal/waf_metrics
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+104
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mariovido
added
type: enhancement
comp: asm iast
Application Security Management (IAST)
labels
Jan 24, 2025
BenchmarksStartupParameters
See matching parameters
SummaryFound 1 performance improvements and 9 performance regressions! Performance is the same for 51 metrics, 2 unstable metrics.
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.46.0-SNAPSHOT~952ab277d5, baseline=1.46.0-SNAPSHOT~56d4919491
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.035 s) : 0, 1035141
Total [baseline] (8.631 s) : 0, 8630998
Agent [candidate] (1.068 s) : 0, 1067656
Total [candidate] (8.639 s) : 0, 8638741
section iast
Agent [baseline] (1.178 s) : 0, 1177870
Total [baseline] (9.213 s) : 0, 9212995
Agent [candidate] (1.183 s) : 0, 1182549
Total [candidate] (9.193 s) : 0, 9192550
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.17 s) : 0, 1170180
Total [baseline] (9.178 s) : 0, 9177990
Agent [candidate] (1.183 s) : 0, 1183399
Total [candidate] (9.175 s) : 0, 9175210
section iast_TELEMETRY_OFF
Agent [baseline] (1.16 s) : 0, 1159552
Total [baseline] (9.196 s) : 0, 9196167
Agent [candidate] (1.176 s) : 0, 1176117
Total [candidate] (9.197 s) : 0, 9197419
gantt
title insecure-bank - break down per module: candidate=1.46.0-SNAPSHOT~952ab277d5, baseline=1.46.0-SNAPSHOT~56d4919491
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (714.117 ms) : 0, 714117
BytebuddyAgent [candidate] (723.646 ms) : 0, 723646
GlobalTracer [baseline] (238.31 ms) : 0, 238310
GlobalTracer [candidate] (257.886 ms) : 0, 257886
AppSec [baseline] (54.889 ms) : 0, 54889
AppSec [candidate] (57.413 ms) : 0, 57413
Remote Config [baseline] (713.98 µs) : 0, 714
Remote Config [candidate] (750.283 µs) : 0, 750
Telemetry [baseline] (12.089 ms) : 0, 12089
Telemetry [candidate] (12.817 ms) : 0, 12817
section iast
BytebuddyAgent [baseline] (842.865 ms) : 0, 842865
BytebuddyAgent [candidate] (831.991 ms) : 0, 831991
GlobalTracer [baseline] (231.307 ms) : 0, 231307
GlobalTracer [candidate] (246.497 ms) : 0, 246497
AppSec [baseline] (58.05 ms) : 0, 58050
AppSec [candidate] (57.887 ms) : 0, 57887
IAST [baseline] (21.264 ms) : 0, 21264
IAST [candidate] (21.678 ms) : 0, 21678
Remote Config [baseline] (650.773 µs) : 0, 651
Remote Config [candidate] (683.622 µs) : 0, 684
Telemetry [baseline] (8.571 ms) : 0, 8571
Telemetry [candidate] (8.753 ms) : 0, 8753
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (836.264 ms) : 0, 836264
BytebuddyAgent [candidate] (832.87 ms) : 0, 832870
GlobalTracer [baseline] (229.9 ms) : 0, 229900
GlobalTracer [candidate] (246.629 ms) : 0, 246629
AppSec [baseline] (58.187 ms) : 0, 58187
AppSec [candidate] (58.241 ms) : 0, 58241
IAST [baseline] (21.371 ms) : 0, 21371
IAST [candidate] (21.263 ms) : 0, 21263
Remote Config [baseline] (667.063 µs) : 0, 667
Remote Config [candidate] (664.302 µs) : 0, 664
Telemetry [baseline] (8.748 ms) : 0, 8748
Telemetry [candidate] (8.67 ms) : 0, 8670
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (828.168 ms) : 0, 828168
BytebuddyAgent [candidate] (827.515 ms) : 0, 827515
GlobalTracer [baseline] (228.542 ms) : 0, 228542
GlobalTracer [candidate] (245.658 ms) : 0, 245658
AppSec [baseline] (57.978 ms) : 0, 57978
AppSec [candidate] (57.785 ms) : 0, 57785
IAST [baseline] (20.729 ms) : 0, 20729
IAST [candidate] (20.812 ms) : 0, 20812
Remote Config [baseline] (643.361 µs) : 0, 643
Remote Config [candidate] (688.925 µs) : 0, 689
Telemetry [baseline] (8.514 ms) : 0, 8514
Telemetry [candidate] (8.658 ms) : 0, 8658
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.46.0-SNAPSHOT~952ab277d5, baseline=1.46.0-SNAPSHOT~56d4919491
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.035 s) : 0, 1034723
Total [baseline] (10.441 s) : 0, 10441357
Agent [candidate] (1.057 s) : 0, 1056797
Total [candidate] (10.436 s) : 0, 10436069
section appsec
Agent [baseline] (1.176 s) : 0, 1175605
Total [baseline] (10.727 s) : 0, 10727366
Agent [candidate] (1.19 s) : 0, 1190058
Total [candidate] (10.704 s) : 0, 10703843
section iast
Agent [baseline] (1.165 s) : 0, 1164857
Total [baseline] (10.92 s) : 0, 10920410
Agent [candidate] (1.184 s) : 0, 1184264
Total [candidate] (10.912 s) : 0, 10912297
section profiling
Agent [baseline] (1.257 s) : 0, 1256984
Total [baseline] (10.778 s) : 0, 10777849
Agent [candidate] (1.262 s) : 0, 1261815
Total [candidate] (10.895 s) : 0, 10895075
gantt
title petclinic - break down per module: candidate=1.46.0-SNAPSHOT~952ab277d5, baseline=1.46.0-SNAPSHOT~56d4919491
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (713.792 ms) : 0, 713792
BytebuddyAgent [candidate] (714.746 ms) : 0, 714746
GlobalTracer [baseline] (238.055 ms) : 0, 238055
GlobalTracer [candidate] (255.167 ms) : 0, 255167
AppSec [baseline] (56.488 ms) : 0, 56488
AppSec [candidate] (57.546 ms) : 0, 57546
Remote Config [baseline] (705.525 µs) : 0, 706
Remote Config [candidate] (733.759 µs) : 0, 734
Telemetry [baseline] (10.731 ms) : 0, 10731
Telemetry [candidate] (13.51 ms) : 0, 13510
section appsec
BytebuddyAgent [baseline] (729.871 ms) : 0, 729871
BytebuddyAgent [candidate] (732.737 ms) : 0, 732737
GlobalTracer [baseline] (235.851 ms) : 0, 235851
GlobalTracer [candidate] (252.951 ms) : 0, 252951
AppSec [baseline] (176.463 ms) : 0, 176463
AppSec [candidate] (170.773 ms) : 0, 170773
Remote Config [baseline] (664.212 µs) : 0, 664
Remote Config [candidate] (661.255 µs) : 0, 661
Telemetry [baseline] (8.21 ms) : 0, 8210
Telemetry [candidate] (8.222 ms) : 0, 8222
IAST [baseline] (19.31 ms) : 0, 19310
IAST [candidate] (19.389 ms) : 0, 19389
section iast
BytebuddyAgent [baseline] (832.28 ms) : 0, 832280
BytebuddyAgent [candidate] (833.222 ms) : 0, 833222
GlobalTracer [baseline] (228.87 ms) : 0, 228870
GlobalTracer [candidate] (246.849 ms) : 0, 246849
AppSec [baseline] (58.207 ms) : 0, 58207
AppSec [candidate] (58.176 ms) : 0, 58176
Remote Config [baseline] (657.462 µs) : 0, 657
Remote Config [candidate] (678.167 µs) : 0, 678
Telemetry [baseline] (8.688 ms) : 0, 8688
Telemetry [candidate] (8.726 ms) : 0, 8726
IAST [baseline] (21.199 ms) : 0, 21199
IAST [candidate] (21.572 ms) : 0, 21572
section profiling
BytebuddyAgent [baseline] (704.18 ms) : 0, 704180
BytebuddyAgent [candidate] (708.901 ms) : 0, 708901
GlobalTracer [baseline] (348.089 ms) : 0, 348089
GlobalTracer [candidate] (350.908 ms) : 0, 350908
AppSec [baseline] (56.168 ms) : 0, 56168
AppSec [candidate] (54.235 ms) : 0, 54235
Remote Config [baseline] (724.406 µs) : 0, 724
Remote Config [candidate] (714.517 µs) : 0, 715
Telemetry [baseline] (8.962 ms) : 0, 8962
Telemetry [candidate] (8.852 ms) : 0, 8852
ProfilingAgent [baseline] (96.782 ms) : 0, 96782
ProfilingAgent [candidate] (95.832 ms) : 0, 95832
Profiling [baseline] (96.807 ms) : 0, 96807
Profiling [candidate] (95.86 ms) : 0, 95860
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~952ab277d5, baseline=1.46.0-SNAPSHOT~56d4919491
dateFormat X
axisFormat %s
section baseline
no_agent (387.307 µs) : 361, 413
. : milestone, 387,
iast (507.334 µs) : 484, 530
. : milestone, 507,
iast_FULL (740.809 µs) : 718, 764
. : milestone, 741,
iast_GLOBAL (560.116 µs) : 536, 584
. : milestone, 560,
iast_HARDCODED_SECRET_DISABLED (506.885 µs) : 484, 530
. : milestone, 507,
iast_INACTIVE (457.183 µs) : 435, 479
. : milestone, 457,
iast_TELEMETRY_OFF (495.877 µs) : 472, 519
. : milestone, 496,
tracing (459.103 µs) : 438, 481
. : milestone, 459,
section candidate
no_agent (377.408 µs) : 358, 397
. : milestone, 377,
iast (507.187 µs) : 485, 529
. : milestone, 507,
iast_FULL (740.763 µs) : 719, 763
. : milestone, 741,
iast_GLOBAL (545.695 µs) : 524, 567
. : milestone, 546,
iast_HARDCODED_SECRET_DISABLED (506.287 µs) : 485, 528
. : milestone, 506,
iast_INACTIVE (460.179 µs) : 439, 482
. : milestone, 460,
iast_TELEMETRY_OFF (498.561 µs) : 476, 521
. : milestone, 499,
tracing (448.675 µs) : 427, 470
. : milestone, 449,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~952ab277d5, baseline=1.46.0-SNAPSHOT~56d4919491
dateFormat X
axisFormat %s
section baseline
no_agent (1.345 ms) : 1326, 1365
. : milestone, 1345,
appsec (1.768 ms) : 1745, 1792
. : milestone, 1768,
appsec_no_iast (1.759 ms) : 1735, 1783
. : milestone, 1759,
iast (1.507 ms) : 1483, 1530
. : milestone, 1507,
profiling (1.521 ms) : 1497, 1544
. : milestone, 1521,
tracing (1.471 ms) : 1446, 1496
. : milestone, 1471,
section candidate
no_agent (1.348 ms) : 1328, 1368
. : milestone, 1348,
appsec (1.716 ms) : 1693, 1738
. : milestone, 1716,
appsec_no_iast (1.754 ms) : 1731, 1777
. : milestone, 1754,
iast (1.513 ms) : 1490, 1537
. : milestone, 1513,
profiling (1.517 ms) : 1495, 1540
. : milestone, 1517,
tracing (1.482 ms) : 1458, 1506
. : milestone, 1482,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~952ab277d5, baseline=1.46.0-SNAPSHOT~56d4919491
dateFormat X
axisFormat %s
section baseline
no_agent (14.967 s) : 14967000, 14967000
. : milestone, 14967000,
appsec (15.003 s) : 15003000, 15003000
. : milestone, 15003000,
iast (18.527 s) : 18527000, 18527000
. : milestone, 18527000,
iast_GLOBAL (17.998 s) : 17998000, 17998000
. : milestone, 17998000,
profiling (15.017 s) : 15017000, 15017000
. : milestone, 15017000,
tracing (14.853 s) : 14853000, 14853000
. : milestone, 14853000,
section candidate
no_agent (14.948 s) : 14948000, 14948000
. : milestone, 14948000,
appsec (15.142 s) : 15142000, 15142000
. : milestone, 15142000,
iast (18.657 s) : 18657000, 18657000
. : milestone, 18657000,
iast_GLOBAL (18.047 s) : 18047000, 18047000
. : milestone, 18047000,
profiling (14.906 s) : 14906000, 14906000
. : milestone, 14906000,
tracing (14.976 s) : 14976000, 14976000
. : milestone, 14976000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~952ab277d5, baseline=1.46.0-SNAPSHOT~56d4919491
dateFormat X
axisFormat %s
section baseline
no_agent (1.485 ms) : 1473, 1496
. : milestone, 1485,
appsec (2.377 ms) : 2334, 2420
. : milestone, 2377,
iast (2.122 ms) : 2068, 2176
. : milestone, 2122,
iast_GLOBAL (2.166 ms) : 2111, 2221
. : milestone, 2166,
profiling (1.981 ms) : 1937, 2024
. : milestone, 1981,
tracing (1.949 ms) : 1907, 1991
. : milestone, 1949,
section candidate
no_agent (1.481 ms) : 1469, 1493
. : milestone, 1481,
appsec (2.38 ms) : 2337, 2424
. : milestone, 2380,
iast (2.126 ms) : 2072, 2181
. : milestone, 2126,
iast_GLOBAL (2.155 ms) : 2101, 2210
. : milestone, 2155,
profiling (2.007 ms) : 1962, 2052
. : milestone, 2007,
tracing (1.962 ms) : 1921, 2004
. : milestone, 1962,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
This adds a new value to some metrics which is necessary for the consolidation of ASM Span Tags, Metrics, and Logs across all supported languages. The newly value will be implemented in the following metrics:
Motivation
Our goal is to implement all the missing ASM Span Tags, Metrics, and Logs.
Additional Notes
Also, this PR adds tests that were missing and some improvements to the previous ones.
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: APPSEC-56478