Lint

DataDog · Aug 12, 2024 · 2320656 · 2320656
1 parent 0f4dfea
commit 2320656
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/appsec/src/extension/backtrace.c b/appsec/src/extension/backtrace.c
@@ -32,7 +32,7 @@ static zend_string *_class_field;
 static bool
 php_backtrace_frame_to_datadog_backtrace_frame( // NOLINTNEXTLINE(bugprone-easily-swappable-parameters)
     zval *nonnull php_backtrace_frame, zval *nonnull datadog_backtrace_frame,
-    zend_long index)
+    zend_ulong index)
 {
     if (Z_TYPE_P(php_backtrace_frame) != IS_ARRAY) {
         return false;
@@ -69,7 +69,7 @@ php_backtrace_frame_to_datadog_backtrace_frame( // NOLINTNEXTLINE(bugprone-easil
         zend_hash_add(datadog_backtrace_frame_ht, _frame_line, line);
     }
 
-    int qualified_name_size = Z_STRLEN_P(function);
+    zend_ulong qualified_name_size = Z_STRLEN_P(function);
     qualified_name_size +=
         class ? Z_STRLEN_P(class) + sizeof(QUALIFIED_NAME_SEPARATOR) - 1 : 0;
     zend_string *qualified_name_zstr =

diff --git a/appsec/src/extension/ddappsec.c b/appsec/src/extension/ddappsec.c
@@ -33,6 +33,7 @@
 #include "helper_process.h"
 #include "ip_extraction.h"
 #include "logging.h"
+#include "msgpack_helpers.h"
 #include "network.h"
 #include "php_compat.h"
 #include "php_helpers.h"
@@ -42,7 +43,6 @@
 #include "string_helpers.h"
 #include "tags.h"
 #include "user_tracking.h"
-#include "msgpack_helpers.h"
 
 #include <json/json.h>