Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use correct rust mounts #2627

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

ci: use correct rust mounts #2627

wants to merge 3 commits into from

Conversation

morrisonlevi
Copy link
Collaborator

@morrisonlevi morrisonlevi commented Apr 15, 2024

Description

The old mount was too generic and clobbered over the new cargo and rustup installations. What's strange is the new location installs to where the old one meant to go, but didn't actually. The CI was then mounting stuff over the top of the intended location. Fun sequence of consequences.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

The old ones were too generic and clobbered over the new cargo and
rustup installations. What's strange is the new location installs to
where the old one _meant_ to go, but didn't actually. Fun sequence
of consequences.
@codecov-commenter
Copy link

Codecov Report

Merging #2627 (78dec71) into master (8180fdb) will increase coverage by 0.69%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2627      +/-   ##
============================================
+ Coverage     78.67%   79.37%   +0.69%     
  Complexity     2198     2198              
============================================
  Files           199      199              
  Lines         21955    21955              
============================================
+ Hits          17273    17426     +153     
+ Misses         4682     4529     -153     
Flag Coverage Δ
tracer-extension 78.52% <ø> (ø)
tracer-php 80.57% <ø> (+1.68%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8180fdb...78dec71. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants