Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(profiling): extract SystemProfiler #2794

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

morrisonlevi
Copy link
Collaborator

Description

The global profiler (e.g. PROFILER) and the Profiler::* functions that worked on it were moved into a new struct SystemProfiler.

Motivation

The profiling/src/profiling/mod.rs file was getting big and there was a logical split for functions that worked on the global PROFILER vs those which worked on a profiler object.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@github-actions github-actions bot added the profiling Relates to the Continuous Profiler label Aug 15, 2024
The global profiler (e.g. PROFILER) and the Profiler::* functions that
worked on it were moved into a new struct SystemProfiler.
@pr-commenter
Copy link

pr-commenter bot commented Aug 15, 2024

Benchmarks

Benchmark execution time: 2024-08-15 16:25:56

Comparing candidate commit 48498a4 in PR branch levi/system-profiler with baseline commit b8f3260 in branch florian/remove-mutex.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 27 metrics, 9 unstable metrics.

@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.64%. Comparing base (b8f3260) to head (48498a4).

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##             florian/remove-mutex    #2794   +/-   ##
=======================================================
  Coverage                   78.64%   78.64%           
  Complexity                   2452     2452           
=======================================================
  Files                         143      143           
  Lines                       14276    14276           
=======================================================
  Hits                        11228    11228           
  Misses                       3048     3048           
Flag Coverage Δ
tracer-extension 79.21% <ø> (ø)
tracer-php 78.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8f3260...48498a4. Read the comment docs.

Base automatically changed from florian/remove-mutex to master August 26, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
profiling Relates to the Continuous Profiler tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants