-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(profiling): extract SystemProfiler #2794
base: master
Are you sure you want to change the base?
Conversation
The global profiler (e.g. PROFILER) and the Profiler::* functions that worked on it were moved into a new struct SystemProfiler.
c72a00e
to
48498a4
Compare
BenchmarksBenchmark execution time: 2024-08-15 16:25:56 Comparing candidate commit 48498a4 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 27 metrics, 9 unstable metrics. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## florian/remove-mutex #2794 +/- ##
=======================================================
Coverage 78.64% 78.64%
Complexity 2452 2452
=======================================================
Files 143 143
Lines 14276 14276
=======================================================
Hits 11228 11228
Misses 3048 3048
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
Description
The global profiler (e.g. PROFILER) and the Profiler::* functions that worked on it were moved into a new struct SystemProfiler.
Motivation
The
profiling/src/profiling/mod.rs
file was getting big and there was a logical split for functions that worked on the global PROFILER vs those which worked on a profiler object.Reviewer checklist